[jira] [Comment Edited] (HIVE-21975) Fix incremental compilation

["Steve Carlin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927921#comment-16927921 ] 

Steve Carlin edited comment on HIVE-21975 at 9/11/19 7:07 PM:
--------------------------------------------------------------

Hi [~kgyrtkirk] ,

I just started on the Hive project and hit the same issue.  Also hit the issue in Driver.java.

So I don't mind taking on this bug as a first project, but I did have a question:  Is there a reason you decided to make the scope more generic (Task<?>) as opposed to making it more specific (Task<? extends Serializable>)?   Was it just easier, or did you hit an actual place where the templatized parameter wasn't Serializable?

Thanks!


was (Author: scarlin):
Hi Zoltan,

I just started on the Hive project and hit the same issue.  Also hit the issue in Driver.java.

So I don't mind taking on this bug as a first project, but I did have a question:  Is there a reason you decided to make the scope more generic (Task<?>) as opposed to making it more specific (Task<? extends Serializable>)?   Was it just easier, or did you hit an actual place where the templatized parameter wasn't Serializable?

Thanks!

> Fix incremental compilation
> ---------------------------
>
>                 Key: HIVE-21975
>                 URL: https://issues.apache.org/jira/browse/HIVE-21975
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Priority: Major
>
> we have an incremental compilation issue around SA ; mostly because of "? extends Serializable"
> it could be reproduced with:
> {code}
> git clean -dfx
> mvn install -pl ql -am -DskipTests
> touch `find . -name Sema*A*java` `find . -name Task*Factory.java`
> mvn install -pl ql  -DskipTests
> {code}
> error is:
> {code}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project hive-exec: Compilation failure: Compilation failure: 
> [ERROR] /mnt/work/hwx/hive/master/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:[12573,60] incompatible types: java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends java.io.Serializable>> cannot be converted to java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>>
> [ERROR] /mnt/work/hwx/hive/master/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:[15187,49] incompatible types: java.util.List<org.apache.hadoop.hive.ql.exec.Task<?>> cannot be converted to java.util.List<org.apache.hadoop.hive.ql.exec.Task<? extends java.io.Serializable>>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)