[GitHub] [incubator-nuttx] v01d commented on pull request #1890: make/expression: improving up asm/C/C++ compile times(make with multi-jobs only)

[GitBox <gi...@apache.org>]

v01d commented on pull request #1890:
URL: https://github.com/apache/incubator-nuttx/pull/1890#issuecomment-698343229


   Reducing build time is appreciated. I'm surprised though that it takes 7 minutes with 8 jobs. Maybe the difference is only obvious under certain circumstances. I usually get very reasonable build times with -j8.
   
   This change makes me wonder why we cannot have these CXXFLAGS, CFLAGS definitions in the arch Makefile itself. The board could add any extra defines later. @xiaoxiang781216 has been doing this for a few variables at a time, maybe he knows about that. It would help future changes like this to not have to alter around ~200 files every time.
   
   I think the change looks safe. There are a few cases where we really need the `=` (the evaluation depends on the Makefile including the Make.defs) but I think this is not one of those.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org