[GitHub] mcvsubbu commented on a change in pull request #3838: Fix listFiles method in HadoopPinotFS

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3838: Fix listFiles method in HadoopPinotFS
URL: https://github.com/apache/incubator-pinot/pull/3838#discussion_r259551417
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
 ##########
 @@ -391,8 +391,12 @@ public boolean commitSegmentFile(String tableName, CommittingSegmentDescriptor c
       return false;
     }
 
+    // Cleans up tmp segment files under table dir.
+    // We only clean up tmp segment files in table level dir, so there's no need to list recursively.
+    // See LLCSegmentCompletionHandlers.uploadSegment().
+    // See LLCSegmentCompletionHandlers.uploadSegment().
 
 Review comment:
   looks like we have a duplicate line here. can u remove one of them please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org