You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/21 17:27:11 UTC

[GitHub] [commons-imaging] arturobernalg opened a new pull request #135: IMAGING-291 - Fix Typo

arturobernalg opened a new pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] arturobernalg commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618075011



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -49,11 +49,11 @@
         rgb = -1;
     }
 
-    ColorSpaceSubset(final int total, final int precision, final int[] mins, final int[] maxs) {
+    ColorSpaceSubset(final int total, final int precision, final int[] min, final int[] max) {
         this.total = total;
         this.precision = precision;
-        this.mins = mins;
-        this.maxs = maxs;
+        this.mins = min;
+        this.maxs = max;

Review comment:
       mmm, true.  sorry. changed 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] kinow commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r617902277



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -24,8 +24,8 @@
 
     private static final Logger LOGGER = Logger.getLogger(ColorSpaceSubset.class.getName());
 
-    final int[] mins;
-    final int[] maxs;
+    final int[] min;
+    final int[] max;

Review comment:
       I think these were supposed to be arrays with minimums and maximums. It's common to use the "maximums" or "minimums" as the "locals minimums" for example. So `mins` is a better variable name IMO, so that without seeing the type you know it's an array (especially given it's in a class related to color space).

##########
File path: src/main/java/org/apache/commons/imaging/formats/tiff/constants/MicrosoftHdPhotoTagConstants.java
##########
@@ -152,17 +152,17 @@
     public static final BinaryConstant PIXEL_FORMAT_VALUE_32_BIT_GRAY_FIXED_POINT =
             createMicrosoftHdPhotoGuidEndingWith((byte) 0x3f);
 
-    public static final TagInfoLong EXIF_TAG_TRANSFOMATION = new TagInfoLong(
-            "Transfomation", 0xbc02,
+    public static final TagInfoLong EXIF_TAG_TRANSFORMATION = new TagInfoLong(
+            "Transformation", 0xbc02,
             TiffDirectoryType.EXIF_DIRECTORY_UNKNOWN);
-    public static final int TRANSFOMATION_VALUE_HORIZONTAL_NORMAL = 0;
-    public static final int TRANSFOMATION_VALUE_MIRROR_VERTICAL = 1;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL = 2;
-    public static final int TRANSFOMATION_VALUE_ROTATE_180 = 3;
-    public static final int TRANSFOMATION_VALUE_ROTATE_90_CW = 4;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
-    public static final int TRANSFOMATION_VALUE_ROTATE_270_CW = 7;
+    public static final int TRANSFORMATION_VALUE_HORIZONTAL_NORMAL = 0;
+    public static final int TRANSFORMATION_VALUE_MIRROR_VERTICAL = 1;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL = 2;
+    public static final int TRANSFORMATION_VALUE_ROTATE_180 = 3;
+    public static final int TRANSFORMATION_VALUE_ROTATE_90_CW = 4;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
+    public static final int TRANSFORMATION_VALUE_ROTATE_270_CW = 7;

Review comment:
       Ouch! Good catch! Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] kinow closed pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
kinow closed pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] coveralls commented on pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-824252698


   
   [![Coverage Status](https://coveralls.io/builds/39018090/badge)](https://coveralls.io/builds/39018090)
   
   Coverage remained the same at 76.509% when pulling **5ce3f2569c7df114066ad044c52d70c65aee918c on arturobernalg:feature/IMAGING-291** into **c24b1a67780351451c295e3580afbfee41657a99 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] arturobernalg commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618064315



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -24,8 +24,8 @@
 
     private static final Logger LOGGER = Logger.getLogger(ColorSpaceSubset.class.getName());
 
-    final int[] mins;
-    final int[] maxs;
+    final int[] min;
+    final int[] max;

Review comment:
       HI @kinow 
   Sounds logical. Changed
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] arturobernalg commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618064793



##########
File path: src/main/java/org/apache/commons/imaging/formats/tiff/constants/MicrosoftHdPhotoTagConstants.java
##########
@@ -152,17 +152,17 @@
     public static final BinaryConstant PIXEL_FORMAT_VALUE_32_BIT_GRAY_FIXED_POINT =
             createMicrosoftHdPhotoGuidEndingWith((byte) 0x3f);
 
-    public static final TagInfoLong EXIF_TAG_TRANSFOMATION = new TagInfoLong(
-            "Transfomation", 0xbc02,
+    public static final TagInfoLong EXIF_TAG_TRANSFORMATION = new TagInfoLong(
+            "Transformation", 0xbc02,
             TiffDirectoryType.EXIF_DIRECTORY_UNKNOWN);
-    public static final int TRANSFOMATION_VALUE_HORIZONTAL_NORMAL = 0;
-    public static final int TRANSFOMATION_VALUE_MIRROR_VERTICAL = 1;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL = 2;
-    public static final int TRANSFOMATION_VALUE_ROTATE_180 = 3;
-    public static final int TRANSFOMATION_VALUE_ROTATE_90_CW = 4;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
-    public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
-    public static final int TRANSFOMATION_VALUE_ROTATE_270_CW = 7;
+    public static final int TRANSFORMATION_VALUE_HORIZONTAL_NORMAL = 0;
+    public static final int TRANSFORMATION_VALUE_MIRROR_VERTICAL = 1;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL = 2;
+    public static final int TRANSFORMATION_VALUE_ROTATE_180 = 3;
+    public static final int TRANSFORMATION_VALUE_ROTATE_90_CW = 4;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
+    public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
+    public static final int TRANSFORMATION_VALUE_ROTATE_270_CW = 7;

Review comment:
       ;) just was lucky. I was checking the variable in general




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] arturobernalg commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618075011



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -49,11 +49,11 @@
         rgb = -1;
     }
 
-    ColorSpaceSubset(final int total, final int precision, final int[] mins, final int[] maxs) {
+    ColorSpaceSubset(final int total, final int precision, final int[] min, final int[] max) {
         this.total = total;
         this.precision = precision;
-        this.mins = mins;
-        this.maxs = maxs;
+        this.mins = min;
+        this.maxs = max;

Review comment:
       mmm, true. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] kinow commented on pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-825154265


   Merged, thanks Arturo!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] kinow commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618187200



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -49,11 +49,11 @@
         rgb = -1;
     }
 
-    ColorSpaceSubset(final int total, final int precision, final int[] mins, final int[] maxs) {
+    ColorSpaceSubset(final int total, final int precision, final int[] min, final int[] max) {
         this.total = total;
         this.precision = precision;
-        this.mins = mins;
-        this.maxs = maxs;
+        this.mins = min;
+        this.maxs = max;

Review comment:
       Thanks for fixing these so quickly @arturobernalg ! I will have to merge it tomorrow morning as I'm in a different notebook 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] coveralls edited a comment on pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-824252698


   
   [![Coverage Status](https://coveralls.io/builds/39031702/badge)](https://coveralls.io/builds/39031702)
   
   Coverage remained the same at 76.509% when pulling **23cc474c8f2f8c40a1eeb09fb8e57a1275218f05 on arturobernalg:feature/IMAGING-291** into **c24b1a67780351451c295e3580afbfee41657a99 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] coveralls edited a comment on pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-824252698


   
   [![Coverage Status](https://coveralls.io/builds/39031198/badge)](https://coveralls.io/builds/39031198)
   
   Coverage remained the same at 76.509% when pulling **0730e6f976e8fbcbf2a637be6563038dfdedd2ab on arturobernalg:feature/IMAGING-291** into **c24b1a67780351451c295e3580afbfee41657a99 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] kinow commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618072139



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -49,11 +49,11 @@
         rgb = -1;
     }
 
-    ColorSpaceSubset(final int total, final int precision, final int[] mins, final int[] maxs) {
+    ColorSpaceSubset(final int total, final int precision, final int[] min, final int[] max) {
         this.total = total;
         this.precision = precision;
-        this.mins = mins;
-        this.maxs = maxs;
+        this.mins = min;
+        this.maxs = max;

Review comment:
       mins & maxs ☝️ 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-imaging] arturobernalg commented on a change in pull request #135: IMAGING-291 - Fix Typo

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r618242455



##########
File path: src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -49,11 +49,11 @@
         rgb = -1;
     }
 
-    ColorSpaceSubset(final int total, final int precision, final int[] mins, final int[] maxs) {
+    ColorSpaceSubset(final int total, final int precision, final int[] min, final int[] max) {
         this.total = total;
         this.precision = precision;
-        this.mins = mins;
-        this.maxs = maxs;
+        this.mins = min;
+        this.maxs = max;

Review comment:
       thanks men 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org