You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2013/04/12 20:38:01 UTC
Review Request: Fix CLOUDSTACK-1987: service offerings owned by a domain
show up to domain users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10432/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Prachi Damle, and Ryan Dietrich.
Description
-------
Besides fixing CLOUDSTACK-1987 (caused by AND-OR precedence issues in sql statement), this patch also addressed similar issues for DiskOffering (CLOUDSTACK-1987 and CLOUDSTACK-1989). Additionally, this patch fixed wildcard search inconsistency issue for name parameter.
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1987.
Diffs
-----
server/src/com/cloud/api/query/QueryManagerImpl.java b96691a
Diff: https://reviews.apache.org/r/10432/diff/
Testing
-------
Validated the failed scenario in local setup.
Thanks,
Min Chen
Re: Review Request: Fix CLOUDSTACK-1987: service offerings owned by a domain
show up to domain users
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10432/#review19095
-----------------------------------------------------------
Commit dd486efb77d2dad63991975fd06d033dfa8db445 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dd486ef ]
Fix CLOUDSTACK-1987: Deleted service offering still shows for domain users. Also extend this fix for Disk offering as well.
- ASF Subversion and Git Services
On April 12, 2013, 6:37 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10432/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:37 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prachi Damle, and Ryan Dietrich.
>
>
> Description
> -------
>
> Besides fixing CLOUDSTACK-1987 (caused by AND-OR precedence issues in sql statement), this patch also addressed similar issues for DiskOffering (CLOUDSTACK-1987 and CLOUDSTACK-1989). Additionally, this patch fixed wildcard search inconsistency issue for name parameter.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1987.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java b96691a
>
> Diff: https://reviews.apache.org/r/10432/diff/
>
>
> Testing
> -------
>
> Validated the failed scenario in local setup.
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: Fix CLOUDSTACK-1987: service offerings owned by a domain
show up to domain users
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10432/#review19097
-----------------------------------------------------------
Ship it!
Applied. Please be sure that this is fixed in master as well.
- Chip Childers
On April 12, 2013, 6:37 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10432/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:37 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prachi Damle, and Ryan Dietrich.
>
>
> Description
> -------
>
> Besides fixing CLOUDSTACK-1987 (caused by AND-OR precedence issues in sql statement), this patch also addressed similar issues for DiskOffering (CLOUDSTACK-1987 and CLOUDSTACK-1989). Additionally, this patch fixed wildcard search inconsistency issue for name parameter.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1987.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java b96691a
>
> Diff: https://reviews.apache.org/r/10432/diff/
>
>
> Testing
> -------
>
> Validated the failed scenario in local setup.
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: Fix CLOUDSTACK-1987: service offerings owned by a domain
show up to domain users
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10432/#review19106
-----------------------------------------------------------
Commit 4b1a9f146c7316ba885d0889bd10ae09074e1169 in branch refs/heads/master from Min Chen <mi...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b1a9f1 ]
Fix CLOUDSTACK-1987: Deleted service offering still shows for domain users. Also extend this fix for Disk offering as well.
- ASF Subversion and Git Services
On April 12, 2013, 6:37 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10432/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:37 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prachi Damle, and Ryan Dietrich.
>
>
> Description
> -------
>
> Besides fixing CLOUDSTACK-1987 (caused by AND-OR precedence issues in sql statement), this patch also addressed similar issues for DiskOffering (CLOUDSTACK-1987 and CLOUDSTACK-1989). Additionally, this patch fixed wildcard search inconsistency issue for name parameter.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1987.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java b96691a
>
> Diff: https://reviews.apache.org/r/10432/diff/
>
>
> Testing
> -------
>
> Validated the failed scenario in local setup.
>
>
> Thanks,
>
> Min Chen
>
>
Re: Review Request: Fix CLOUDSTACK-1987: service offerings owned by a domain
show up to domain users
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10432/#review19110
-----------------------------------------------------------
Commit 4b1a9f146c7316ba885d0889bd10ae09074e1169 in branch refs/heads/internallb from Min Chen <mi...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b1a9f1 ]
Fix CLOUDSTACK-1987: Deleted service offering still shows for domain users. Also extend this fix for Disk offering as well.
- ASF Subversion and Git Services
On April 12, 2013, 6:37 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10432/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 6:37 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prachi Damle, and Ryan Dietrich.
>
>
> Description
> -------
>
> Besides fixing CLOUDSTACK-1987 (caused by AND-OR precedence issues in sql statement), this patch also addressed similar issues for DiskOffering (CLOUDSTACK-1987 and CLOUDSTACK-1989). Additionally, this patch fixed wildcard search inconsistency issue for name parameter.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1987.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/query/QueryManagerImpl.java b96691a
>
> Diff: https://reviews.apache.org/r/10432/diff/
>
>
> Testing
> -------
>
> Validated the failed scenario in local setup.
>
>
> Thanks,
>
> Min Chen
>
>