You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/20 01:01:43 UTC

[kudu-CR] sasl: provide a mutex implementation to cyrus-sasl

Hello Dan Burkert, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4762

to review the following change.

Change subject: sasl: provide a mutex implementation to cyrus-sasl
......................................................................

sasl: provide a mutex implementation to cyrus-sasl

In looking around the SASL code I found some notes that it is not
inherently thread-safe, unless we provide it a mutex implementation
using sasl_set_mutex(). This does just that.

Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
---
M src/kudu/rpc/sasl_common.cc
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/4762/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] sasl: provide a mutex implementation to cyrus-sasl

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: sasl: provide a mutex implementation to cyrus-sasl
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] sasl: provide a mutex implementation to cyrus-sasl

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: sasl: provide a mutex implementation to cyrus-sasl
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] sasl: provide a mutex implementation to cyrus-sasl

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: sasl: provide a mutex implementation to cyrus-sasl
......................................................................


sasl: provide a mutex implementation to cyrus-sasl

In looking around the SASL code I found some notes that it is not
inherently thread-safe, unless we provide it a mutex implementation
using sasl_set_mutex(). This does just that.

Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
Reviewed-on: http://gerrit.cloudera.org:8080/4762
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/rpc/sasl_common.cc
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I357de7f5df86d1663440b53cef715d92bee2cbe2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>