[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42676: [SPARK-44961][PYTHON][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42676:
URL: https://github.com/apache/spark/pull/42676#discussion_r1305276723


##########
python/pyspark/sql/connect/streaming/query.py:
##########
@@ -33,8 +36,6 @@
     StreamingQueryException as CapturedStreamingQueryException,
 )
 
-__all__ = ["StreamingQuery", "StreamingQueryManager"]

Review Comment:
   All `connect` is an internal module. So I we don't need this



##########
python/pyspark/sql/connect/streaming/__init__.py:
##########
@@ -14,9 +14,3 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-
-from pyspark.sql.connect.streaming.query import StreamingQuery  # noqa: F401
-from pyspark.sql.connect.streaming.readwriter import DataStreamReader  # noqa: F401
-from pyspark.sql.connect.streaming.readwriter import DataStreamWriter  # noqa: F401
-from pyspark.sql.connect.streaming.query import StreamingQueryManager  # noqa: F401
-from pyspark.errors import StreamingQueryException  # noqa: F401

Review Comment:
   All `connect` is an internal module. So I we don't need this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org