You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Paul Querna <ch...@force-elite.com> on 2005/09/18 03:50:13 UTC
Re: svn commit: r232338 [1/2] - in /httpd/mod_smtpd/trunk: ./ Makefile.in
README autogen.sh configure configure.ac mod_smtpd.h smtp.h smtp_core.c smtp_protocol.c
Sorry for bring this up so late....
soc-rian@apache.org wrote:
> Author: soc-rian
> Date: Fri Aug 12 10:43:04 2005
> New Revision: 232338
>
> URL: http://svn.apache.org/viewcvs?rev=232338&view=rev
> Log:
> More file hierarchy changes.
......
> Added: httpd/mod_smtpd/trunk/mod_smtpd.h
> URL: http://svn.apache.org/viewcvs/httpd/mod_smtpd/trunk/mod_smtpd.h?rev=232338&view=auto
> ==============================================================================
> --- httpd/mod_smtpd/trunk/mod_smtpd.h (added)
> +++ httpd/mod_smtpd/trunk/mod_smtpd.h Fri Aug 12 10:43:04 2005
....
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode,
> + unrecognized_command,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, connect,
> + (request_rec *r, smtpd_return_data *in));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, reset_transaction,
> + (request_rec *r));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, helo,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, ehlo,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, mail,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, rcpt,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, vrfy,
> + (request_rec *r, smtpd_return_data *in,
> + char *str));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, quit,
> + (request_rec *r, smtpd_return_data *in));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, data,
> + (request_rec *r, smtpd_return_data *in));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, data_post,
> + (request_rec *r, smtpd_return_data *in));
> + APR_DECLARE_EXTERNAL_HOOK(smtpd, SMTPD, smtpd_retcode, queue,
> + (request_rec *r, smtpd_return_data *in));
> +
> +
Why are these APR Optional Functions?
Why can't they be AP_DECLARE_HOOK's?
-Paul
Re: svn commit: r232338 [1/2] - in /httpd/mod_smtpd/trunk: ./ Makefile.in README autogen.sh configure configure.ac mod_smtpd.h smtp.h smtp_core.c smtp_protocol.c
Posted by Rian Hunter <ri...@MIT.EDU>.
On Sep 18, 2005, at 3:30 PM, Paul Querna wrote:
> Rian Hunter wrote:
>
>> On Sep 17, 2005, at 9:50 PM, Paul Querna wrote:
>>
>>> Sorry for bring this up so late....
>>> [ snip ]
>>>
>>>>
>>>>
>>>
>>> Why are these APR Optional Functions?
>>>
>>> Why can't they be AP_DECLARE_HOOK's?
>>>
>>> -Paul
>>>
>>>
>> I decided that they should be optional because after talking to
>> some people I was under the impression that only modules included
>> in the core httpd distribution should use AP_DECLARE_HOOK and all
>> others should be optional hooks because they might not always be
>> loaded.
>>
>
> If you are running a SMTP server, mod_smtpd will always be loaded,
> and if its not, it should be treated as a fatal error The optional
> functions will make it silently ignore any missing symbols, which
> isn't a good thing.
I have no problem changing it, but if I do I'll have to change all
the currently checked in mod_smtpd plugins. Are you 100% this is the
right thing to do?
-rian
Re: svn commit: r232338 [1/2] - in /httpd/mod_smtpd/trunk: ./ Makefile.in
README autogen.sh configure configure.ac mod_smtpd.h smtp.h smtp_core.c smtp_protocol.c
Posted by Paul Querna <ch...@force-elite.com>.
Rian Hunter wrote:
>
> On Sep 17, 2005, at 9:50 PM, Paul Querna wrote:
>
>> Sorry for bring this up so late....
>> [ snip ]
>>>
>>
>> Why are these APR Optional Functions?
>>
>> Why can't they be AP_DECLARE_HOOK's?
>>
>> -Paul
>>
>
> I decided that they should be optional because after talking to some
> people I was under the impression that only modules included in the core
> httpd distribution should use AP_DECLARE_HOOK and all others should be
> optional hooks because they might not always be loaded.
If you are running a SMTP server, mod_smtpd will always be loaded, and
if its not, it should be treated as a fatal error The optional
functions will make it silently ignore any missing symbols, which isn't
a good thing.
-Paul
Re: svn commit: r232338 [1/2] - in /httpd/mod_smtpd/trunk: ./ Makefile.in README autogen.sh configure configure.ac mod_smtpd.h smtp.h smtp_core.c smtp_protocol.c
Posted by Rian Hunter <ri...@MIT.EDU>.
On Sep 17, 2005, at 9:50 PM, Paul Querna wrote:
> Sorry for bring this up so late....
> [ snip ]
>>
>
> Why are these APR Optional Functions?
>
> Why can't they be AP_DECLARE_HOOK's?
>
> -Paul
>
I decided that they should be optional because after talking to some
people I was under the impression that only modules included in the
core httpd distribution should use AP_DECLARE_HOOK and all others
should be optional hooks because they might not always be loaded.
If this is not the case, this should change soon.
-rian