You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/25 08:52:06 UTC
[GitHub] [ignite-3] valepakh opened a new pull request, #1033: IGNITE-17527 Add short aliases for options
valepakh opened a new pull request, #1033:
URL: https://github.com/apache/ignite-3/pull/1033
https://issues.apache.org/jira/browse/IGNITE-17527
In addition to adding short options, this also adds additional checking when parsing URL options and provide meaningful messages when passing invalid URLs or network addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] valepakh commented on a diff in pull request #1033: IGNITE-17527 Add short aliases for options
Posted by GitBox <gi...@apache.org>.
valepakh commented on code in PR #1033:
URL: https://github.com/apache/ignite-3/pull/1033#discussion_r963735147
##########
modules/cli/src/main/java/org/apache/ignite/cli/commands/connect/ConnectCommand.java:
##########
@@ -44,7 +46,7 @@ public class ConnectCommand extends BaseCommand implements Runnable {
@Override
public void run() {
CallExecutionPipeline.builder(connectCall)
- .inputProvider(() -> new ConnectCallInput(nodeUrl))
+ .inputProvider(() -> new ConnectCallInput(nodeUrl.toString()))
Review Comment:
In this command `nodeUrl` is a parameter, not an option, and it can't be null - it will taken from either the parameter or from the config via the `descriptionKey`, and will throw an error in case the config doesn't have this parameter defined.
I added a test which shows that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes merged pull request #1033: IGNITE-17527 Add short aliases for options
Posted by GitBox <gi...@apache.org>.
SammyVimes merged PR #1033:
URL: https://github.com/apache/ignite-3/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #1033: IGNITE-17527 Add short aliases for options
Posted by GitBox <gi...@apache.org>.
kgusakov commented on code in PR #1033:
URL: https://github.com/apache/ignite-3/pull/1033#discussion_r963699652
##########
modules/cli/src/main/java/org/apache/ignite/cli/commands/connect/ConnectCommand.java:
##########
@@ -44,7 +46,7 @@ public class ConnectCommand extends BaseCommand implements Runnable {
@Override
public void run() {
CallExecutionPipeline.builder(connectCall)
- .inputProvider(() -> new ConnectCallInput(nodeUrl))
+ .inputProvider(() -> new ConnectCallInput(nodeUrl.toString()))
Review Comment:
Shouldn't we handle the `nodeUrl==null` case here? Doesn't `NodeUrlMixin` suit well here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #1033: IGNITE-17527 Add short aliases for options
Posted by GitBox <gi...@apache.org>.
kgusakov commented on code in PR #1033:
URL: https://github.com/apache/ignite-3/pull/1033#discussion_r963742664
##########
modules/cli/src/main/java/org/apache/ignite/cli/commands/connect/ConnectCommand.java:
##########
@@ -44,7 +46,7 @@ public class ConnectCommand extends BaseCommand implements Runnable {
@Override
public void run() {
CallExecutionPipeline.builder(connectCall)
- .inputProvider(() -> new ConnectCallInput(nodeUrl))
+ .inputProvider(() -> new ConnectCallInput(nodeUrl.toString()))
Review Comment:
Oh, I see, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org