You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "RanaPriyansh (via GitHub)" <gi...@apache.org> on 2026/09/20 01:11:49 UTC

[PR] fix: preserve typed errors for S3 and GCS list requests [arrow-rs-object-store]

RanaPriyansh opened a new pull request, #857:
URL: https://github.com/apache/arrow-rs-object-store/pull/857

   # Which issue does this PR close?
   
   Closes #851.
   
   # Rationale for this change
   
   S3 and GCS list failures currently return `Generic` for HTTP statuses that other operations map to specific error variants.
   
   # What changes are included in this PR?
   
   Route list request failures through the existing `RetryError::error` mapper. Retain the request prefix as the error path and preserve `RetryError` as the source.
   
   Add local HTTP mock tests for both providers. The tests cover collected list streams, delimiter lists, 401 responses, valid empty results, and unmapped 500 responses.
   
   Recorded local runs passed `cargo test --features aws,gcp --lib` (231 tests), ordinary `cargo test`, formatting, and strict all-features/all-targets Clippy.
   Default tests emitted four integration-macro warnings. External cloud integration tests and remote CI were not run.
   
   Production-target Clippy checks also passed separately with `aws-base` and `gcp-base`, without default features.
   A supplemental all-targets check without reqwest failed. The exact baseline produced the same existing errors.
   
   AI assistance produced the implementation, tests, and draft text. An independent AI review inspected the diff and logs.
   
   # Are there any user-facing changes?
   
   S3 and GCS list request failures use these existing error mappings:
   
   - 401: `Unauthenticated`
   - 403: `PermissionDenied`
   - 404: `NotFound`
   - 304: `NotModified`
   - 409: `AlreadyExists`
   - 412: `Precondition`
   
   Other statuses remain `Generic`. Error text can change because the mapper preserves `RetryError` directly instead of the private list-request wrapper.
   
   Error paths contain the actual request prefix. Public `Path("prefix")` list calls report `"prefix/"`. Bucket-root calls report an empty path.
   Raw paginated-list prefixes remain unchanged. No public API signatures change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: preserve typed errors for S3 and GCS list requests [arrow-rs-object-store]

Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb commented on PR #857:
URL: https://github.com/apache/arrow-rs-object-store/pull/857#issuecomment-6558318776

   Thank you for the contribution. The change may well be correct, but I am closing this PR under the arrow-rs guidance on AI generated submissions: https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#ai-generated-submissions
   
   Maintainer review time is the scarcest resource in this project. This account has opened more than 80 PRs across many repositories since October 1, and currently has 9 PRs open in object_store totaling roughly 3,900 added lines for maintainers to review:
   
   - #873 Test external CryptoProvider integration through public S3 APIs (+481/-0)
   - #869 Test downstream HTTP and crypto configurations (+671/-41)
   - #867 fix: validate Azure delegation key coverage (+544/-89)
   - #866 fix: honor fsync for local deletes (+175/-16)
   - #861 fix: honor GCS skip_signature during uploads (+85/-2)
   - #860 GCP: Request uncompressed credential and signing responses (+904/-3)
   - #859 test: cover local filesystem put and delete errors (+110/-0)
   - #858 fix: accept complete HTTP responses for full ranges (+589/-24)
   - #857 fix: preserve typed errors for S3 and GCS list requests (+348/-2)
   
   That volume is far more than we can review. As discussed in #873, we will focus on #861 and I am closing the other draft PRs.
   
   If one of these changes matters to you after #861 is resolved, please open a focused PR with a short description in your own words, one you have reviewed and understand, and we'd be happy to help with review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: preserve typed errors for S3 and GCS list requests [arrow-rs-object-store]

Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb closed pull request #857: fix: preserve typed errors for S3 and GCS list requests
URL: https://github.com/apache/arrow-rs-object-store/pull/857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: preserve typed errors for S3 and GCS list requests [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #857:
URL: https://github.com/apache/arrow-rs-object-store/pull/857#issuecomment-6224943707

   Marking as draft per https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6224909416 so i can find the PRs that need attention. Thank you 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org