[kudu-CR] KUDU-3781: add TLS transport support for HMS client

["Zoltan Chovan (Code Review)" <ge...@cloudera.org>]

Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24383 )

Change subject: KUDU-3781: add TLS transport support for HMS client
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc
File src/kudu/thrift/client.cc:

http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc@78
PS2, Line 78: it's
nit: it


http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc@86
PS2, Line 86: sf.loadTrustedCertificates(options.tls_trusted_ca_cert_file.c_str());
Is it possible, that a bad path would trigger the throw in loadTrustedCertificates()[0]? Would that crash the client?

[0] https://github.com/apache/thrift/blob/7107195895ce4a2f9c0621a9753e8bf6ed3b92b2/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L1071



-- 
To view, visit http://gerrit.cloudera.org:8080/24383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9658323ed9aebdfdf8e6847c9c3129f5c8517c65
Gerrit-Change-Number: 24383
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 09:12:11 +0000
Gerrit-HasComments: Yes