You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/24 08:55:28 UTC

Re: Review Request 32432: LENS-431 : Make hiveConfLock transient in AbstractQueryContext

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32432/
-----------------------------------------------------------

(Updated March 24, 2015, 7:55 a.m.)


Review request for lens and Jaideep dhok.


Summary (updated)
-----------------

LENS-431 : Make hiveConfLock transient in AbstractQueryContext


Bugs: LENS-431
    https://issues.apache.org/jira/browse/LENS-431


Repository: lens


Description
-------

Made is transient and added initTransientState to be called upon restart.
Included unit test.


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6390bd4 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 06ce751 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 18eb2dc 

Diff: https://reviews.apache.org/r/32432/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.835s]
[INFO] Lens .............................................. SUCCESS [2.047s]
[INFO] Lens API .......................................... SUCCESS [5.173s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.357s]
[INFO] Lens Cube ......................................... SUCCESS [2:06.121s]
[INFO] Lens DB storage ................................... SUCCESS [11.004s]
[INFO] Lens Query Library ................................ SUCCESS [6.346s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:25.942s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [22.658s]
[INFO] Lens Server ....................................... SUCCESS [5:19.948s]
[INFO] Lens client ....................................... SUCCESS [21.921s]
[INFO] Lens CLI .......................................... SUCCESS [2:54.490s]
[INFO] Lens Examples ..................................... SUCCESS [1.123s]
[INFO] Lens Distribution ................................. SUCCESS [9.034s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.106s]
[INFO] Lens Regression ................................... SUCCESS [0.472s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:58.571s
[INFO] Finished at: Tue Mar 24 07:39:55 UTC 2015
[INFO] Final Memory: 99M/949M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32432: LENS-431 : Make hiveConfLock transient in AbstractQueryContext

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32432/#review77541
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 24, 2015, 7:55 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32432/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 7:55 a.m.)
> 
> 
> Review request for lens and Jaideep dhok.
> 
> 
> Bugs: LENS-431
>     https://issues.apache.org/jira/browse/LENS-431
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Made is transient and added initTransientState to be called upon restart.
> Included unit test.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6390bd4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 06ce751 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 18eb2dc 
> 
> Diff: https://reviews.apache.org/r/32432/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.835s]
> [INFO] Lens .............................................. SUCCESS [2.047s]
> [INFO] Lens API .......................................... SUCCESS [5.173s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.357s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.121s]
> [INFO] Lens DB storage ................................... SUCCESS [11.004s]
> [INFO] Lens Query Library ................................ SUCCESS [6.346s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:25.942s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [22.658s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.948s]
> [INFO] Lens client ....................................... SUCCESS [21.921s]
> [INFO] Lens CLI .......................................... SUCCESS [2:54.490s]
> [INFO] Lens Examples ..................................... SUCCESS [1.123s]
> [INFO] Lens Distribution ................................. SUCCESS [9.034s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.106s]
> [INFO] Lens Regression ................................... SUCCESS [0.472s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:58.571s
> [INFO] Finished at: Tue Mar 24 07:39:55 UTC 2015
> [INFO] Final Memory: 99M/949M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 32432: LENS-431 : Make hiveConfLock transient in AbstractQueryContext

Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32432/#review77540
-----------------------------------------------------------

Ship it!


Ship It!

- Himanshu Gahlaut


On March 24, 2015, 7:55 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32432/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 7:55 a.m.)
> 
> 
> Review request for lens and Jaideep dhok.
> 
> 
> Bugs: LENS-431
>     https://issues.apache.org/jira/browse/LENS-431
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Made is transient and added initTransientState to be called upon restart.
> Included unit test.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6390bd4 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java 06ce751 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 18eb2dc 
> 
> Diff: https://reviews.apache.org/r/32432/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.835s]
> [INFO] Lens .............................................. SUCCESS [2.047s]
> [INFO] Lens API .......................................... SUCCESS [5.173s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.357s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.121s]
> [INFO] Lens DB storage ................................... SUCCESS [11.004s]
> [INFO] Lens Query Library ................................ SUCCESS [6.346s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:25.942s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [22.658s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.948s]
> [INFO] Lens client ....................................... SUCCESS [21.921s]
> [INFO] Lens CLI .......................................... SUCCESS [2:54.490s]
> [INFO] Lens Examples ..................................... SUCCESS [1.123s]
> [INFO] Lens Distribution ................................. SUCCESS [9.034s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.106s]
> [INFO] Lens Regression ................................... SUCCESS [0.472s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:58.571s
> [INFO] Finished at: Tue Mar 24 07:39:55 UTC 2015
> [INFO] Final Memory: 99M/949M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>