[GitHub] [tinkerpop] spmallette commented on issue #1257: dotnet: add session connection

[GitBox <gi...@apache.org>]

spmallette commented on issue #1257: dotnet: add session connection
URL: https://github.com/apache/tinkerpop/pull/1257#issuecomment-611592164
 
 
   I've merged this PR even though it was closed. This change did need to go to `3.3-dev` because we need session functionality on that branch. I added a change to remove the non-standard argument from the "close" message:
   
   https://github.com/apache/tinkerpop/commit/fb334df4845d6fef0258d12f9da08f36efae50f5
   
   I merged `3.3-dev` to `3.4-dev` with `-s ours` to ignore these changes as they were already brought in on #1263 and #1276. I also brought in the test improvement manually to `3.4-dev` that i had added to `3.3-dev` in the above commit manually with:
   
   https://github.com/apache/tinkerpop/commit/183b2c9e1bc4fb448b96bbe419b0bc0fca68eab7
   
   I think we just need to merge #1275 at this point and all GLVs will be consistent on `3.3-dev` and `3.4-dev`. I expect to do a more full review of docs and testing at that point and then go on to consider what is necessary to make `master` wholly consistent. 
   
   thanks @heljoyLiu for getting things this far.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services