You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2018/06/29 20:01:03 UTC
Review Request 67789: SENTRY-2293: Fix logging parameters on
SentryHDFSServiceProcessor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67789/
-----------------------------------------------------------
Review request for sentry and Sergio Pena.
Repository: sentry
Description
-------
SentryHDFSServiceProcessor method getPathsUpdatesFrom has a log message where parameters are swapped. See below and fix it
{noformat}
LOGGER.debug("PATHS updates requested from HDFS [ImgNum={}, SeqNum={}]",
request.getPathSeqNum(), request.getPathImgNum());
{noformat}
Diffs
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 9041ff674
Diff: https://reviews.apache.org/r/67789/diff/1/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 67789: SENTRY-2293: Fix logging parameters on
SentryHDFSServiceProcessor
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67789/#review205580
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On June 29, 2018, 8:01 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67789/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 8:01 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-2293
> https://issues.apache.org/jira/browse/SENTRY-2293
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SentryHDFSServiceProcessor method getPathsUpdatesFrom has a log message where parameters are swapped. See below and fix it
> {noformat}
> LOGGER.debug("PATHS updates requested from HDFS [ImgNum={}, SeqNum={}]",
> request.getPathSeqNum(), request.getPathImgNum());
> {noformat}
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 9041ff674
>
>
> Diff: https://reviews.apache.org/r/67789/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 67789: SENTRY-2293: Fix logging parameters on
SentryHDFSServiceProcessor
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67789/
-----------------------------------------------------------
(Updated June 29, 2018, 8:01 p.m.)
Review request for sentry and Sergio Pena.
Bugs: SENTRY-2293
https://issues.apache.org/jira/browse/SENTRY-2293
Repository: sentry
Description
-------
SentryHDFSServiceProcessor method getPathsUpdatesFrom has a log message where parameters are swapped. See below and fix it
{noformat}
LOGGER.debug("PATHS updates requested from HDFS [ImgNum={}, SeqNum={}]",
request.getPathSeqNum(), request.getPathImgNum());
{noformat}
Diffs
-----
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 9041ff674
Diff: https://reviews.apache.org/r/67789/diff/1/
Testing
-------
Thanks,
Arjun Mishra