You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/06/01 21:41:26 UTC

[GitHub] [avro] siad007 opened a new pull request #906: AVRO-2855: PHP Add alias support.

siad007 opened a new pull request #906:
URL: https://github.com/apache/avro/pull/906


   * Added alias support
   * Remove endian conditions
   Added following tests:
   * testToAvroIncludesAliases
   * testValidateFieldAliases 
   * testValidateRecordAliases
   * testValidateFixedAliases
   * testValidateEnumAliases
   * testValidateSameAliasMultipleFields
   * testValidateRepeatedAliases


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] Fokko commented on pull request #906: AVRO-2855: PHP Add alias support and drop endian condition

Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #906:
URL: https://github.com/apache/avro/pull/906#issuecomment-676577112


   @siad007 Sorry for the late response. Could you rebase against latest master?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] siad007 commented on pull request #906: AVRO-2855: PHP Add alias support and drop endian condition

Posted by GitBox <gi...@apache.org>.
siad007 commented on pull request #906:
URL: https://github.com/apache/avro/pull/906#issuecomment-676594294


   sure @Fokko done 😃 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] Fokko merged pull request #906: AVRO-2855: PHP Add alias support and drop endian condition

Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #906:
URL: https://github.com/apache/avro/pull/906


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org