You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/09/01 16:20:47 UTC
[I] Metric snapshot batches can be partially persisted [rocketmq-dashboard]
yuluo-yx opened a new issue, #2913:
URL: https://github.com/apache/rocketmq-dashboard/issues/2913
MybatisPlusMetricSnapshotRepository.saveAll inserts samples one by one without a transaction. If a later insert fails, earlier rows remain committed even though collection processing reports a failure. This leaves an incomplete snapshot batch that later alert evaluation can read.
Reproduction:
1. Save a batch containing multiple metric samples.
2. Make the mapper fail on a later insert.
Actual: earlier inserts can remain persisted.
Expected: saveAll should run in one transaction so the entire sample batch commits or rolls back together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Metric snapshot batches can be partially persisted [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #2913:
URL: https://github.com/apache/rocketmq-dashboard/issues/2913#issuecomment-5536535053
Resolved by #2907 (merged into rocketmq-studio as 0b131e63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Metric snapshot batches can be partially persisted [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #2913: Metric snapshot batches can be partially persisted
URL: https://github.com/apache/rocketmq-dashboard/issues/2913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Metric snapshot batches can be partially persisted [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2913:
URL: https://github.com/apache/rocketmq-dashboard/issues/2913#issuecomment-5498243786
**Issue Evaluation**
Category: `bug` | Status: **Needs Info**
The issue references `MybatisPlusMetricSnapshotRepository.saveAll()`, but this class does not exist in the current codebase. I searched for:
- `MetricSnapshot` (no results)
- `saveAll` in repository classes (no matching implementation)
Could you clarify:
1. Which branch or version contains this class?
2. Is this a proposed class for new functionality, or an existing one?
3. Can you provide a link to the specific file/line?
Without being able to locate the referenced code, I cannot verify the transaction behavior described.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org