[GitHub] nlu90 commented on a change in pull request #3029: Nwang/add bolt based flatmap streamlet

[GitBox <gi...@apache.org>]

nlu90 commented on a change in pull request #3029: Nwang/add bolt based flatmap streamlet
URL: https://github.com/apache/incubator-heron/pull/3029#discussion_r218631796
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/streamlet/Streamlet.java
 ##########
 @@ -85,6 +86,13 @@
   <T> Streamlet<T> flatMap(
       SerializableFunction<R, ? extends Iterable<? extends T>> flatMapFn);
 
+  /**
+   * Return a new Streamlet by applying a bolt to each element of this Streamlet and
+   * flattening the result
+   * @param flatMapBolt The rich bolt that is used to emit tuples from each input element
+   */
+  <T> Streamlet<T> flatMap(IRichBolt flatMapBolt);
 
 Review comment:
   What is the use case for this new api?
   
   This looks weird to me. When using the high-level DSL, users don't need to worry about bolt/spout.
   
   @srkukarni Could you please take a look and provide some feedback?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services