[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1563: SOLR-16748: Official Dockerfile cleanup Args & GPG/SHA

["sonatype-lift[bot] (via GitHub)" <gi...@apache.org>]

sonatype-lift[bot] commented on code in PR #1563:
URL: https://github.com/apache/solr/pull/1563#discussion_r1242654942


##########
dev-tools/scripts/buildAndPushRelease.py:
##########
@@ -217,7 +217,7 @@ def pushLocal(version, root, rcNum, localDir):
   rev = open('%s/solr/distribution/build/release/.gitrev' % root, encoding='UTF-8').read()
 
   dir = 'solr-%s-RC%d-rev-%s' % (version, rcNum, rev)
-  os.makedirs('%s/%s/solr' % (localDir, dir))
+  os.makedirs('%s/%s/solr/%s' % (localDir, dir, version))

Review Comment:
   <picture><img alt="3% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/3/display.svg"></picture>
   
   <b>*E111:</b>*  indentation is not a multiple of 4
   
   ❗❗ <b>3 similar findings have been found in this PR</b>
   
   <details><summary>🔎 Expand here to view all instances of this finding</summary><br/>
     
     
   <div align=\"center\">
   
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | dev-tools/scripts/buildAndPushRelease.py | [230](https://github.com/apache/solr/blob/c5a253d9b3aa2d4ca2df6cf87f37b4e49bbdd5a5/dev-tools/scripts/buildAndPushRelease.py#L230) |
   | dev-tools/scripts/smokeTestRelease.py | [1133](https://github.com/apache/solr/blob/c5a253d9b3aa2d4ca2df6cf87f37b4e49bbdd5a5/dev-tools/scripts/smokeTestRelease.py#L1133) |
   | dev-tools/scripts/smokeTestRelease.py | [1136](https://github.com/apache/solr/blob/c5a253d9b3aa2d4ca2df6cf87f37b4e49bbdd5a5/dev-tools/scripts/smokeTestRelease.py#L1136) |
   <p><a href="https://lift.sonatype.com/results/github.com/apache/solr/01H3WEGYDGQ0C1DW115KAGWRAT?t=Flake8|E111" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details>
   
   
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> commands</summary>
   
   You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
   
   



##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -1130,11 +1130,14 @@ def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys,
   else:
     # An ordinary release has a 'solr' sub folder
     for text, subURL in getDirEntries(baseURL):
-      if text.lower() == 'solr/':
+      if text.lower() == "solr/":
+        solrPath = subURL
+    for text, subURL in getDirEntries(solrPath):

Review Comment:
   <picture><img alt="0% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/0/display.svg"></picture>
   
   <b>*reportOptionalIterable:</b>*  Object of type "None" cannot be used as iterable value
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> commands</summary>
   
   You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org