You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/08 15:20:24 UTC
[GitHub] [cloudstack] alexandremattioli opened a new pull request, #6876: Update en.json
alexandremattioli opened a new pull request, #6876:
URL: https://github.com/apache/cloudstack/pull/6876
Rephrasing confusing messages
### Description
This PR rephrases some confusing messages
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
N/A
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on code in PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#discussion_r1044509054
##########
ui/public/locales/en.json:
##########
@@ -2637,22 +2637,22 @@
"message.volume.state.attaching": "The volume is attaching to a volume from Ready state.",
"message.volume.state.copying": "Volume is copying from image store to primary, in case it's an uploaded volume.",
"message.volume.state.creating": "The volume is being created.",
-"message.volume.state.destroy": "The volume was destroyed, and cannot be recovered.",
+"message.volume.state.destroy": "The volume has been destroyed and cannot be recovered.",
Review Comment:
This tooltip appears when a volume is in the destroyed state. But if the volume is not expunged, it can still be recovered. I think we should remove the last part of this phrase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1308235485
Thanks @DaanHoogland @nvazquez @stephankruggg for approving my first PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307404083
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1350640538
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307388528
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307391281
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1354582376
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307466534
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307402815
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1350640128
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1350648797
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6876 (QA-JID-17)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1309069998
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1309068867
@alexandremattioli the ui build is failing so verification is not (yet) possible
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307469437
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6876](https://codecov.io/gh/apache/cloudstack/pull/6876?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (138e7e5) into [main](https://codecov.io/gh/apache/cloudstack/commit/4c5a2ba3a6eb6399390c2f8963cb26e0e35fc058?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c5a2ba) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6876 +/- ##
=========================================
Coverage 10.84% 10.84%
Complexity 7105 7105
=========================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
=========================================
Hits 26622 26622
Misses 215526 215526
Partials 3269 3269
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307390240
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#issuecomment-1307389726
@nvazquez could you review this or me please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on a diff in pull request #6876: Update en.json
Posted by GitBox <gi...@apache.org>.
alexandremattioli commented on code in PR #6876:
URL: https://github.com/apache/cloudstack/pull/6876#discussion_r1044515632
##########
ui/public/locales/en.json:
##########
@@ -2637,22 +2637,22 @@
"message.volume.state.attaching": "The volume is attaching to a volume from Ready state.",
"message.volume.state.copying": "Volume is copying from image store to primary, in case it's an uploaded volume.",
"message.volume.state.creating": "The volume is being created.",
-"message.volume.state.destroy": "The volume was destroyed, and cannot be recovered.",
+"message.volume.state.destroy": "The volume has been destroyed and cannot be recovered.",
Review Comment:
Makes perfect sense, thanks for your input. I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org