You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2020/03/03 02:09:47 UTC

[kudu-CR] [cmake] Fix ASAN build on macOS 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15342

to review the following change.


Change subject: [cmake] Fix ASAN build on macOS
......................................................................

[cmake] Fix ASAN build on macOS

Fixes the following error on macOS:

CMake Error at CMakeLists.txt:1183 (get_filename_component):
  get_filename_component called with incorrect number of arguments

Change-Id: Ic5f0039c6f48214ccf0948536533fdfb58c10619
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/15342/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5f0039c6f48214ccf0948536533fdfb58c10619
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] [cmake] Fix ASAN build on macOS

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15342 )

Change subject: [cmake] Fix ASAN build on macOS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5f0039c6f48214ccf0948536533fdfb58c10619
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Mar 2020 02:33:31 +0000
Gerrit-HasComments: No

[kudu-CR] [cmake] Fix ASAN build on macOS

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15342 )

Change subject: [cmake] Fix ASAN build on macOS
......................................................................

[cmake] Fix ASAN build on macOS

Fixes the following error on macOS:

CMake Error at CMakeLists.txt:1183 (get_filename_component):
  get_filename_component called with incorrect number of arguments

Change-Id: Ic5f0039c6f48214ccf0948536533fdfb58c10619
Reviewed-on: http://gerrit.cloudera.org:8080/15342
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5f0039c6f48214ccf0948536533fdfb58c10619
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>