You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:32:46 UTC
[GitHub] [shardingsphere] wenweibin opened a new pull request #7546: fix problem：Statement setFetchDirection not supported #6661
wenweibin opened a new pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546
Fixes #6661
Changes proposed in this pull request:
- **AbstractUnsupportedOperationStatement:** delete `getFetchDirection` and `setFetchDirection` method
- **AbstractStatementAdapter:** add field `fecthDirection`; add the implementation of `getFetchDirection` and `setFetchDirection` method.
The setting of the `setFetchDirection` are invalid for many DB drivers,such as MySQL,H2，`getFetchDirection` always return 1000. Instead of returning directly the `getFetchDirection` result of the first underlying Statement, I think adding a field named `fecthDirection` is a better choice , which ensures that the getter and setter of `fetchDirection`are consistent in ShardingSphere.
- **CircuitBreakerStatement:** add the implementation of `getFetchDirection` and `setFetchDirection` method.
- **UnsupportedOperationStatementTest:** delete `assertGetFetchDirection` and `assertSetFetchDirection`
- **StatementAdapterTest:** add the `assertSetFetchDirection` and `assertFetchDirection` method
This PR is to solve the problem in issue 6661.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546#issuecomment-696562722
## Pull Request Test Coverage Report for [Build 14969](https://coveralls.io/builds/33627682)
* **5** of **7** **(71.43%)** changed or added relevant lines in **2** files are covered.
* **40** unchanged lines in **8** files lost coverage.
* Overall coverage increased (+**0.03%**) to **35.111%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-jdbc/shardingsphere-jdbc-governance/src/main/java/org/apache/shardingsphere/driver/governance/internal/circuit/statement/CircuitBreakerStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-governance%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fgovernance%2Finternal%2Fcircuit%2Fstatement%2FCircuitBreakerStatement.java#L104) | 0 | 2 | 0.0%
<!-- | **Total:** | **5** | **7** | **71.43%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L84) | 1 | 98.08% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/UpdateStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FUpdateStatement.java#L48) | 1 | 50.0% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptInsertOnUpdateTokenGenerator.java#L60) | 2 | 96.15% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingDeleteStatementValidator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingDeleteStatementValidator.java#L42) | 3 | 50.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L56) | 3 | 61.9% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/SelectStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FSelectStatement.java#L54) | 3 | 25.0% |
| [shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Finit%2Fimpl%2FAbstractBootstrapInitializer.java#L83) | 9 | 62.5% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingUpdateStatementValidator.java#L76) | 18 | 52.78% |
<!-- | **Total:** | **40** | | -->
| Totals | [](https://coveralls.io/builds/33627682) |
| :-- | --: |
| Change from base [Build 14959](https://coveralls.io/builds/33610642): | 0.03% |
| Covered Lines: | 36637 |
| Relevant Lines: | 104346 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546#issuecomment-696562722
## Pull Request Test Coverage Report for [Build 14969](https://coveralls.io/builds/33627682)
* **5** of **7** **(71.43%)** changed or added relevant lines in **2** files are covered.
* **40** unchanged lines in **8** files lost coverage.
* Overall coverage increased (+**0.03%**) to **35.111%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-jdbc/shardingsphere-jdbc-governance/src/main/java/org/apache/shardingsphere/driver/governance/internal/circuit/statement/CircuitBreakerStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-governance%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fgovernance%2Finternal%2Fcircuit%2Fstatement%2FCircuitBreakerStatement.java#L104) | 0 | 2 | 0.0%
<!-- | **Total:** | **5** | **7** | **71.43%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L84) | 1 | 98.08% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/UpdateStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FUpdateStatement.java#L48) | 1 | 50.0% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptInsertOnUpdateTokenGenerator.java#L60) | 2 | 96.15% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingDeleteStatementValidator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingDeleteStatementValidator.java#L42) | 3 | 50.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L56) | 3 | 61.9% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/SelectStatement.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FSelectStatement.java#L54) | 3 | 25.0% |
| [shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/init/impl/AbstractBootstrapInitializer.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Finit%2Fimpl%2FAbstractBootstrapInitializer.java#L83) | 9 | 62.5% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidator.java](https://coveralls.io/builds/33627682/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingUpdateStatementValidator.java#L76) | 18 | 52.78% |
<!-- | **Total:** | **40** | | -->
| Totals | [](https://coveralls.io/builds/33627682) |
| :-- | --: |
| Change from base [Build 14959](https://coveralls.io/builds/33610642): | 0.03% |
| Covered Lines: | 36637 |
| Relevant Lines: | 104346 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wenweibin commented on pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
wenweibin commented on pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546#issuecomment-696574364
> Can you fix the CI?
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wenweibin commented on pull request #7546: fix problem：Statement setFetchDirection not supported #6661
Posted by GitBox <gi...@apache.org>.
wenweibin commented on pull request #7546:
URL: https://github.com/apache/shardingsphere/pull/7546#issuecomment-696574364
> Can you fix the CI?
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org