[jira] [Commented] (JDO-652) Provision of a typesafe refactor-friendly query capability for JDOQL

["Craig L Russell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JDO-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904229#comment-16904229 ] 

Craig L Russell commented on JDO-652:
-------------------------------------

I'm looking at Ch14-Query.odt. Very nice.

p 35 the change around "ifgetColumnLabel" is hard to review so please check the spacing. 

p 37 "query using the query query API" query is duplicated.

p 37 to 41 we should try for consistency with the font used for java language names (methods, interfaces, packages)

p 40 "JDOQLType query" should be {color:#000000}JDOQLTypedQuery{color}

p 45 is there a missing cast for firstname to name here? "select firstname, salary, manager as reportsTo"

Similar casts seem to be missing in several sections

 

> Provision of a typesafe refactor-friendly query capability for JDOQL
> --------------------------------------------------------------------
>
>                 Key: JDO-652
>                 URL: https://issues.apache.org/jira/browse/JDO-652
>             Project: JDO
>          Issue Type: New Feature
>          Components: api, specification, tck
>            Reporter: Andy Jefferson
>            Assignee: Michael Bouschen
>            Priority: Major
>             Fix For: JDO 3.2
>
>         Attachments: Ch14-Query.odt, JDO-652-api-ifTheElse.txt, JDO-652-api-patch-Andy.txt, JDO-652-patch4.txt, typesafe.patch, typesafe_manifest.patch
>
>
> There are various querying capabilities of this type around. JPA2 has its Criteria query API. Third party solutions like QueryDSL also exist, in its case providing a JDOQL implementation (as well as JPQL, and HQL). We should seriously consider introducing something along these lines in the JDO2.4 timeframe. 
> There is a comparison of JPA Criteria with QueryDSL over at 
> http://source.mysema.com/forum/mvnforum/viewthread_thread,49



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)