[GitHub] [pulsar-helm-chart] MBcom commented on a diff in pull request #282: Allow setting nodePort Option for proxy service

["MBcom (via GitHub)" <gi...@apache.org>]

MBcom commented on code in PR #282:
URL: https://github.com/apache/pulsar-helm-chart/pull/282#discussion_r1089984777


##########
charts/pulsar/templates/proxy-service.yaml:
##########
@@ -40,6 +40,9 @@ spec:
     - name: "{{ .Values.tcpPrefix }}pulsar"
       port: {{ .Values.proxy.ports.pulsar }}
       protocol: TCP
+      {{- if .Values.proxy.service.nodePort }}
+      nodePort: {{ .Values.proxy.service.nodePort }}
+      {{- end }}
     {{- end }}
     {{- if and .Values.tls.enabled .Values.tls.proxy.enabled }}
     - name: https

Review Comment:
   Good idea. I have added that now. I also changed the naming from "nodePort" to "pulsarNodePort" to make it clearer which endpoint is meant.



##########
charts/pulsar/templates/proxy-service.yaml:
##########
@@ -48,6 +51,9 @@ spec:
     - name: "{{ .Values.tlsPrefix }}pulsarssl"
       port: {{ .Values.proxy.ports.pulsarssl }}
       protocol: TCP
+      {{- if .Values.proxy.service.nodePort }}
+      nodePort: {{ .Values.proxy.service.nodePort }}

Review Comment:
   I think it might be confusing to use different names here, since TLS is either enabled or not. So there is no way to enable HTTP and HTTPS at the same time, so it doesn't make sense to me to set different values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org