You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fantonangeli (via GitHub)" <gi...@apache.org> on 2025/04/01 10:51:35 UTC
Re: [PR] kie-tools-issues#2641: Upgrade Patternfly to v5 [incubator-kie-tools]
fantonangeli commented on code in PR #2853:
URL: https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r2022618573
##########
packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx:
##########
@@ -153,38 +155,41 @@ export const ImpersonationPageSection: React.FC<{}> = () => {
/>
}
>
- <FormGroup label={"User"}>
+ <FormGroup label={"User"} style={{ maxWidth: "500px" }}>
<TextInput
className={
username && username === impersonationUsername
- ? "pf-c-form-control pf-m-success"
- : "pf-c-form-control pf-m-expanded"
+ ? "pf-v5-c-form-control pf-v5-m-success"
+ : "pf-v5-c-form-control pf-v5-m-expanded"
}
id="username"
aria-label="Username"
autoFocus={false}
placeholder={`None (currently as '${authSessionInfo.username}')`}
tabIndex={1}
- style={{ maxWidth: "400px" }}
value={username ?? ""}
- onChange={setUsername}
+ onChange={(_event, val) => setUsername(val)}
/>
</FormGroup>
- <FormGroup label={"Groups"} helperText={"Comma-separated list, no spaces."}>
+ <FormGroup label={"Groups"} style={{ maxWidth: "500px" }}>
<TextInput
Review Comment:
Same as the username textbox
##########
packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx:
##########
@@ -153,38 +155,41 @@ export const ImpersonationPageSection: React.FC<{}> = () => {
/>
}
>
- <FormGroup label={"User"}>
+ <FormGroup label={"User"} style={{ maxWidth: "500px" }}>
<TextInput
className={
username && username === impersonationUsername
- ? "pf-c-form-control pf-m-success"
- : "pf-c-form-control pf-m-expanded"
+ ? "pf-v5-c-form-control pf-v5-m-success"
+ : "pf-v5-c-form-control pf-v5-m-expanded"
Review Comment:
It seems pf-m-success and pf-m-expanded have no `-v5` prefix in v5
```suggestion
? "pf-v5-c-form-control pf-m-success"
: "pf-v5-c-form-control pf-m-expanded"
```
##########
packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx:
##########
@@ -153,38 +155,41 @@ export const ImpersonationPageSection: React.FC<{}> = () => {
/>
}
>
- <FormGroup label={"User"}>
+ <FormGroup label={"User"} style={{ maxWidth: "500px" }}>
<TextInput
Review Comment:
Under PF4 it was the class pf-m-success to show the CheckCircle icon when the input was valid but now we need to use the validated property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org