You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:39:46 UTC
[GitHub] [hudi] manojpec opened a new pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
manojpec opened a new pull request #3811:
URL: https://github.com/apache/hudi/pull/3811
## What is the purpose of the pull request
InetAddress.getLocalHost() can take up as much as 30+seconds if the network
configurations are not done right. This might be due to local hostname
missing IPv6 address mapping in /etc/hosts or network configs slowing down
any IPv6 name resolutions. If this API is used for logging verbose messages
and that too in the hot code path, it can lead to order of magnitude
slowness in the overall task completion.
## Brief change log
* BitCaskDiskMap - modified the logging message to exclude localhost name resolution
## Verify this pull request
* TestCleaner verified with and without fixes
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#issuecomment-944837898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2669",
"triggerID" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"triggerType" : "PUSH"
}, {
"hash" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2670",
"triggerID" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"triggerType" : "PUSH"
}, {
"hash" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2699",
"triggerID" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 24d793b0fb531e889b0ec65ce98b305cdad6f9fc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2699)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#issuecomment-944837898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2669",
"triggerID" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"triggerType" : "PUSH"
}, {
"hash" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2670",
"triggerID" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"triggerType" : "PUSH"
}, {
"hash" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2699",
"triggerID" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a42742b2db8fabf273cb787541ad9d3afcb4bc5e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2670)
* 24d793b0fb531e889b0ec65ce98b305cdad6f9fc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2699)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#discussion_r730627352
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -133,9 +132,7 @@ private void initFile(File writeOnlyFile) throws IOException {
writeOnlyFile.getParentFile().mkdir();
}
writeOnlyFile.createNewFile();
- LOG.info("Spilling to file location " + writeOnlyFile.getAbsolutePath() + " in host ("
- + InetAddress.getLocalHost().getHostAddress() + ") with hostname (" + InetAddress.getLocalHost().getHostName()
- + ")");
+ LOG.info("Spilling to file location " + writeOnlyFile.getAbsolutePath());
Review comment:
Right, debug is better here. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#issuecomment-944837898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#issuecomment-944837898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2669",
"triggerID" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"triggerType" : "PUSH"
}, {
"hash" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2670",
"triggerID" : "a42742b2db8fabf273cb787541ad9d3afcb4bc5e",
"triggerType" : "PUSH"
}, {
"hash" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "24d793b0fb531e889b0ec65ce98b305cdad6f9fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a42742b2db8fabf273cb787541ad9d3afcb4bc5e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2670)
* 24d793b0fb531e889b0ec65ce98b305cdad6f9fc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#issuecomment-944837898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88f12741bb8dc46d157f03d66e17f8a775119e39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88f12741bb8dc46d157f03d66e17f8a775119e39 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #3811:
URL: https://github.com/apache/hudi/pull/3811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3811: [HUDI-2561] BitCaskDiskMap - avoiding hostname resolution when logging messages
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3811:
URL: https://github.com/apache/hudi/pull/3811#discussion_r730265167
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -133,9 +132,7 @@ private void initFile(File writeOnlyFile) throws IOException {
writeOnlyFile.getParentFile().mkdir();
}
writeOnlyFile.createNewFile();
- LOG.info("Spilling to file location " + writeOnlyFile.getAbsolutePath() + " in host ("
- + InetAddress.getLocalHost().getHostAddress() + ") with hostname (" + InetAddress.getLocalHost().getHostName()
- + ")");
+ LOG.info("Spilling to file location " + writeOnlyFile.getAbsolutePath());
Review comment:
should we move this to debug level rather than info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org