You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/05/23 10:02:30 UTC
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/672
HAWQ-751. Add plr, pgcrypto, gporca into Apache HAWQ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq save3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #672
----
commit 7e8893c8582bb16e721de3bd401ff9c15aacb5ed
Author: Paul Guo <pa...@gmail.com>
Date: 2016-05-23T09:59:00Z
HAWQ-751. Add plr, pgcrypto, gporca into Apache HAWQ
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/672#issuecomment-221501008
Merged into upstream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/672#discussion_r64319427
--- Diff: configure ---
@@ -1545,7 +1543,8 @@ Optional Packages:
--with-perl build Perl modules (PL/Perl)
--with-python build Python modules (PL/Python)
--with-java build Java modules (PL/Java)
- --with-r build R modules (PL/R)
+ --with-r build R modules (PL/R)
--- End diff --
--with-perl, ... follows postgresql though I agree with you but we can keep it for tradition. pgcypto typo, yes, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/672#issuecomment-221454446
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-751. Add plr, pgcrypto, gporca i...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/672#discussion_r64318728
--- Diff: configure ---
@@ -1545,7 +1543,8 @@ Optional Packages:
--with-perl build Perl modules (PL/Perl)
--with-python build Python modules (PL/Python)
--with-java build Java modules (PL/Java)
- --with-r build R modules (PL/R)
+ --with-r build R modules (PL/R)
--- End diff --
It would be better to use:
```
--with-plperl
--with-plpython
--with-pljava
--with-plr
--with-pgcrypto
```
Also the comment for "with-pgcrypto" should be "build with pgcrypto"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---