You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/02/24 03:18:07 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17214: [improve] configure whether function consumer should skip to latest

michaeljmarshall commented on code in PR #17214:
URL: https://github.com/apache/pulsar/pull/17214#discussion_r1116467566


##########
pulsar-functions/proto/src/main/proto/Function.proto:
##########
@@ -165,6 +165,7 @@ message SourceSpec {
     bool cleanupSubscription = 11;
     SubscriptionPosition subscriptionPosition = 12;
     uint64 negativeAckRedeliveryDelayMs = 13;
+    bool skipToLatest = 14;

Review Comment:
   @nlu90 - was this discussed on the mailing list? This is a protobuf change. We have a general rule that those go through the PIP process. While there could be exceptions, we should always post about these kinds of changes on the mailing list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org