[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on pull request #102: add alpakka-kafka prefix to version numbers

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #102:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/102#issuecomment-1630637140

   @pjfanning Can we use the sane naming scheme we did for Pekko core for `@deprecated`, i.e. using https://github.com/apache/incubator-pekko/blob/b0fdac259bd57fdd481483f3fe9a7aec6e1ff38a/cluster-typed/src/main/scala/org/apache/pekko/cluster/typed/ClusterSingleton.scala#L307 we should have
   
   ```scala
   @deprecated("use `Committer.flow` or `Committer.sink` instead of direct usage", "Alpakka Kafka 2.0.0")
   ```
   
   and not
   
   ```scala
   @deprecated("use `Committer.flow` or `Committer.sink` instead of direct usage", "alpakka-kafka 2.0.0")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org