You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2024/01/29 10:03:00 UTC
[jira] [Comment Edited] (CASSANDRA-19289) Expose core_pool_size, max_pool_size and max_tasks_queued in nodetool tpstats / system_views.thread_pools
[ https://issues.apache.org/jira/browse/CASSANDRA-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811801#comment-17811801 ]
Stefan Miklosovic edited comment on CASSANDRA-19289 at 1/29/24 10:02 AM:
-------------------------------------------------------------------------
I did this small change https://github.com/apache/cassandra/pull/3066/commits/5e045beecff8363d59b33abeb031964ca33dd097
ThreadPoolExecutorPlus extends ThreadPoolExecutorBase and it is better if we override it in base so Plus version of that does not need to do anything. This also fixes the case for UDFExecutorService which extends ThreadPoolExecutorBase but not ThreadPoolExecutorPlus so the figure for maxTasksQueued would be wrong there (-1). This executor is created only when a UDF function is created (enabled_user_defined_functions = true in cassandra.yaml).
was (Author: smiklosovic):
I did this small change https://github.com/apache/cassandra/pull/3066/commits/5e045beecff8363d59b33abeb031964ca33dd097
ThreadPoolExecutorPlus extends ThreadPoolExecutorBase and it is better if we override it in base so Plus version of that does not need to do anything. This also fixes the case for UDFExecutorService which extends ThreadPoolExecutorBase but not ThreadPoolExecutorPlus so the figure for maxTasksQueued would be wrong there (-1).
> Expose core_pool_size, max_pool_size and max_tasks_queued in nodetool tpstats / system_views.thread_pools
> ---------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19289
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Legacy/Core, Tool/nodetool
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It would be nice to expose this information so it is visible from cql(sh) / nodetool tpstats. I briefly checked the complexity of this and it should be quite easy, just add few columns in both and put the sizes to metrics so we can read that.
> Without this, I think the only way to know the sizes is to read it from JMX. I just prefer some more handy and faster way to check the sizes so I can adjust them accordingly when necessary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org