You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/04 11:14:47 UTC

[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3161: Java 11

gemmellr edited a comment on pull request #3161:
URL: https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638780631


   > @gemmellr It was my fault as I had asked @ehsavoie to send the PR, as I wanted to work on it.. and have other reviewing it.
   
   Ok, I was just going by the description commenting it was for testing not review.
   
   > @gemmellr I'm really tickling to merge this though... do you see anything else missing? (besides ammending a jira code)
   
   The new error prone dependency additions in all the modules omit the scope / optional elements. It is being governed in dependencyManagement, but as the diff context shows the existing deps in the modules have those where applicable, so its a bit inconsistent to omit here and would probably be clearer if added.
   
   EDIT: somehow missed the property being fixed, removed that bit of comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org