[GitHub] [geode] albertogpz commented on issue #4205: GEODE-6971: CqAttributesFactory to offer fluid API

["albertogpz (GitHub)" <gi...@apache.org>]

> The tests are compiled with the new method signature and the test will execute the test code on the old servers which had the old method signature. The fix was to use reflection to grab the correct method/method signature and do it at runtime instead of compile time.
> 
> Two potential problems:
> 1.) The problem now is if a client application that is compiled against the old signature, attempts to run the compiled code on a new server..
> 
> 2.) If this change is just client side changes, then this would only be an issue if they update the geode jar without recompiling the client...

The way I see it (please, correct me if I am wrong) is that the method modified is only run on the client.
If this is so, the test is doing something strange: It compiles the client with the new library but then runs the client with the old one. That's why you needed to use reflection to get the right version of the method.
I think clients should be expected to be recompiled if the geode library is updated.

[ Full content available at: https://github.com/apache/geode/pull/4205 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org