[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2224: xtensa/esp32: Add SPI Flash hardware encryption I/O support

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2224:
URL: https://github.com/apache/incubator-nuttx/pull/2224#discussion_r521901902



##########
File path: arch/xtensa/src/esp32/esp32_spiflash.c
##########
@@ -1044,24 +1427,12 @@ static ssize_t esp32_read(FAR struct mtd_dev_s *dev, off_t offset,
                           size_t nbytes, FAR uint8_t *buffer)
 {
   int ret;
-  uint8_t *tmpbuff = buffer;
   FAR struct esp32_spiflash_s *priv = MTD2PRIV(dev);
 
 #ifdef CONFIG_ESP32_SPIFLASH_DEBUG
   finfo("esp32_read(%p, 0x%x, %d, %p)\n", dev, offset, nbytes, buffer);
 #endif
 
-#ifdef CONFIG_XTENSA_USE_SEPARATE_IMEM
-  if (esp32_ptr_extram(buffer))
-    {
-      tmpbuff = xtensa_imm_malloc(nbytes);
-      if (tmpbuff == NULL)
-        {
-          return (ssize_t)-ENOMEM;
-        }
-    }
-#endif
-

Review comment:
       Why these were removed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org