You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/01/27 13:49:59 UTC
[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #756:
Make the size of Hive client pool configurable
aokolnychyi opened a new pull request #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756
Right now, the size of the client pool in `HiveCatalog` is hardcoded to 2. This PR makes it configurable by calling another constructor of `HiveClientPool` in `HiveCatalog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] aokolnychyi commented on issue #756: Make the
size of Hive client pool configurable
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on issue #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756#issuecomment-578877108
Yeah, I was going to add documentation to our configs in a follow-up PR as we have multiple such configs by now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue merged pull request #756: Make the size
of Hive client pool configurable
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #756: Make the size
of Hive client pool configurable
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756#issuecomment-578874751
I agree, this looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull
request #756: Make the size of Hive client pool configurable
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756#discussion_r371249306
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -50,7 +50,7 @@
private boolean closed;
public HiveCatalog(Configuration conf) {
- this.clients = new HiveClientPool(2, conf);
+ this.clients = new HiveClientPool(conf);
Review comment:
This will bump the default size to 5. Maybe, we can change the default value to 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #756: Make the size
of Hive client pool configurable
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #756: Make the size of Hive client pool configurable
URL: https://github.com/apache/incubator-iceberg/pull/756#issuecomment-578874975
One more thing: should this be documented somewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org