You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/31 12:41:16 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #312: mima check on pull requests
pjfanning opened a new pull request, #312:
URL: https://github.com/apache/incubator-pekko-http/pull/312
* relates to #311
* I don't know for definite but that PR looks like the removed method should cause a mima failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #312: mima check on pull requests
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #312:
URL: https://github.com/apache/incubator-pekko-http/pull/312#issuecomment-1702284130
Can we also please make a decision on https://lists.apache.org/thread/4oymvkv6t415pocdtc6l1vxssoflbw9f and https://github.com/apache/incubator-pekko/pull/532 ? The whole point of that thread is to actually implement a proper handling of MiMa that sticks to semver and actually automatically deals with changes where people add functionality (doing MiMa checks against a hardcoded Pekko 1.0.0/1.1.0 is not enough, we should actually be doing MiMa checks against the latest release of the software against every PR).
I understand the solution may not be the cleanest (although tbh we kind of have our hands tied due to ASF process) but what I am suggesting is standard and normal in Scala OS projects, its not some crazy out there idea (otherwise this feature in dynver wouldn't even exist).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning closed pull request #312: mima check on pull requests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #312: mima check on pull requests
URL: https://github.com/apache/incubator-pekko-http/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #312: mima check on pull requests
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #312:
URL: https://github.com/apache/incubator-pekko-http/pull/312#issuecomment-1700980727
I ran the `mimaReportBinaryIssues` locally and it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #312: mima check on pull requests
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #312:
URL: https://github.com/apache/incubator-pekko-http/pull/312#issuecomment-1701009958
What about add a dedicated binary-compatibility-checks workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin closed pull request #312: mima check on pull requests
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #312: mima check on pull requests
URL: https://github.com/apache/incubator-pekko-http/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org