You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by Larry <ro...@ornl.gov> on 2004/11/23 19:56:37 UTC

uridnsbl_max_domains config is broken

I am using SpamAssassin 3.0.1.

There is an option documented in the URIDNSBL plugin called
uridnsbl_max_domains, but there is no code in URIDNSBL.pm to parse this
option from the config file.  Therefore, I get the following error:

# spamassassin --lint
config: SpamAssassin failed to parse line, skipping: uridnsbl_max_domains   3

The following patch will fix it:

*** 268,273 ****
--- 268,277 ----
      $opts->{conf}->{uridnsbl_timeout} = $opts->{value};
      $self->inhibit_further_callbacks(); return 1;
    }
+   elsif ($key eq 'uridnsbl_max_domains') {
+     $opts->{conf}->{uridnsbl_max_domains} = $opts->{value};
+     $self->inhibit_further_callbacks(); return 1;
+   }
    elsif ($key eq 'uridnsbl_skip_domain') {
      foreach my $domain (split(/\s+/, $opts->{value})) {
        $opts->{conf}->{uridnsbl_skip_domains}->{lc $domain} = 1;


Also, there is a handy-looking option called uridnsbl_skip_domain.  Does
this option have any default values?  If not, can anybody suggest a good
list to start with?  So far I have

uridnsbl_skip_domain aol.com comcast.net comcast.com msn.com



Re: uridnsbl_max_domains config is broken

Posted by Jeff Chan <je...@surbl.org>.
On Tuesday, November 23, 2004, 10:56:37 AM, Larry wrote:
> Also, there is a handy-looking option called uridnsbl_skip_domain.  Does
> this option have any default values?  If not, can anybody suggest a good
> list to start with?  So far I have

> uridnsbl_skip_domain aol.com comcast.net comcast.com msn.com

As Theo mentioned those have been populated in 3.0.1.
Here's a couple earlier tickets about it:

  http://bugzilla.spamassassin.org/show_bug.cgi?id=3805
  http://bugzilla.spamassassin.org/show_bug.cgi?id=3886

The data source is the top DNS hits into the SURBL whitelist,
a growing list of which can be found at:

  http://www.surbl.org/dns-queries.whitelist.counts.txt

It's the top 125 of these that are going into SA, and the
data is increasing from 10 to 90 days worth now, in order
to get a hopefully more representative and stable sample.

Jeff C.
-- 
Jeff Chan
mailto:jeffc@surbl.org
http://www.surbl.org/


Re: uridnsbl_max_domains config is broken

Posted by Bill Landry <bi...@pointshare.com>.
----- Original Message ----- 
From: "Larry" <ro...@ornl.gov>

> I am using SpamAssassin 3.0.1.
>
> There is an option documented in the URIDNSBL plugin called
> uridnsbl_max_domains, but there is no code in URIDNSBL.pm to parse this
> option from the config file.  Therefore, I get the following error:
>
> # spamassassin --lint
> config: SpamAssassin failed to parse line, skipping: uridnsbl_max_domains
3
>
> The following patch will fix it:
>
> *** 268,273 ****
> --- 268,277 ----
>       $opts->{conf}->{uridnsbl_timeout} = $opts->{value};
>       $self->inhibit_further_callbacks(); return 1;
>     }
> +   elsif ($key eq 'uridnsbl_max_domains') {
> +     $opts->{conf}->{uridnsbl_max_domains} = $opts->{value};
> +     $self->inhibit_further_callbacks(); return 1;
> +   }
>     elsif ($key eq 'uridnsbl_skip_domain') {
>       foreach my $domain (split(/\s+/, $opts->{value})) {
>         $opts->{conf}->{uridnsbl_skip_domains}->{lc $domain} = 1;
>
>
> Also, there is a handy-looking option called uridnsbl_skip_domain.  Does
> this option have any default values?  If not, can anybody suggest a good
> list to start with?  So far I have
>
> uridnsbl_skip_domain aol.com comcast.net comcast.com msn.com

If you are running SA 3.0.1, you should have a list of about 100 domains
already defined in the SA 25_uribl.cf file.

Bill


Re: uridnsbl_max_domains config is broken

Posted by Theo Van Dinter <fe...@kluge.net>.
On Tue, Nov 23, 2004 at 01:56:37PM -0500, Larry wrote:
> There is an option documented in the URIDNSBL plugin called
> uridnsbl_max_domains, but there is no code in URIDNSBL.pm to parse this
> option from the config file.  Therefore, I get the following error:

In general, bugs need to be reported to Bugzilla
(bugzilla.spamassassin.org).  In this case, however, it's already fixed
for 3.0.2:

http://bugzilla.spamassassin.org/show_bug.cgi?id=3930

> Also, there is a handy-looking option called uridnsbl_skip_domain.  Does
> this option have any default values?  If not, can anybody suggest a good
> list to start with?

The top 125 whitelisted domains are in 25_uribl.cf already.  You can add more
if you want of course. :)

-- 
Randomly Generated Tagline:
"The distributions may be developed that way, but to get into the mainline
 kernel you have to go through the pope." - David Parsons