You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/06/02 07:45:13 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1537: [CELEBORN-630] Update release shell script to package new spark and f…
zhongqiangczq opened a new pull request, #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537
…link version
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1537: [CELEBORN-630] Binary release artifact should package all versions of Spark and Flink clients
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537#discussion_r1214076566
##########
build/make-distribution.sh:
##########
@@ -215,8 +215,9 @@ function build_flink_client {
if [ "$RELEASE" == "true" ]; then
build_service
build_spark_client -Pspark-2.4
- build_spark_client -Pspark-3.3
- build_flink_client -Pflink-1.14
+ build_spark_client -Pspark-3.4
+ build_flink_client -Pflink-1.15
Review Comment:
yes, it should include.
At before, i think flink-1.15 will be backward compatible flink-1.14, so flink-1.14 can be removed. I check again that flink-1.14 is little incompatible with flink-1.15. so flink-1.14 must be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1537: [CELEBORN-630] Binary release artifact should package all versions of Spark and Flink clients
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537#discussion_r1214076566
##########
build/make-distribution.sh:
##########
@@ -215,8 +215,9 @@ function build_flink_client {
if [ "$RELEASE" == "true" ]; then
build_service
build_spark_client -Pspark-2.4
- build_spark_client -Pspark-3.3
- build_flink_client -Pflink-1.14
+ build_spark_client -Pspark-3.4
+ build_flink_client -Pflink-1.15
Review Comment:
yes, it should include.
At before, i think flink-1.15 will be backward compatible flink-1.14, so flink-1.14 can be removed. I check again that flink-1.14 is little not compatible with flink-1.15. so flink-1.14 must be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1537: [CELEBORN-630] Binary release artifact should package all versions of Spark and Flink clients
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537#issuecomment-1573455399
Thanks, merge to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1537: [CELEBORN-630] Update release shell script to package new spark and f…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537#issuecomment-1573315018
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1537](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ba3aa79) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/4f1ca8c960eba453d6abd64a1a2beaeb28a8ecf2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4f1ca8c) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
- Coverage 45.91% 45.88% -0.03%
==========================================
Files 158 158
Lines 9888 9888
Branches 967 967
==========================================
- Hits 4539 4536 -3
- Misses 5048 5051 +3
Partials 301 301
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1537: [CELEBORN-630] Update release shell script to package new spark and f…
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1537:
URL: https://github.com/apache/incubator-celeborn/pull/1537#discussion_r1214066445
##########
build/make-distribution.sh:
##########
@@ -215,8 +215,9 @@ function build_flink_client {
if [ "$RELEASE" == "true" ]; then
build_service
build_spark_client -Pspark-2.4
- build_spark_client -Pspark-3.3
- build_flink_client -Pflink-1.14
+ build_spark_client -Pspark-3.4
+ build_flink_client -Pflink-1.15
Review Comment:
why not include flink 1.14?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1537: [CELEBORN-630] Binary release artifact should package all versions of Spark and Flink clients
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1537: [CELEBORN-630] Binary release artifact should package all versions of Spark and Flink clients
URL: https://github.com/apache/incubator-celeborn/pull/1537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org