[GitHub] [ozone] sodonnel commented on a change in pull request #2591: HDDS-5690. Speed up TestContainerReplication by removing testSkipDemmissionAndMaintenanceNode

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2591:
URL: https://github.com/apache/ozone/pull/2591#discussion_r697422649



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
##########
@@ -524,4 +527,33 @@ public void testvalidateContainerPlacementSingleRackCluster() {
     assertTrue(stat.isPolicySatisfied());
     assertEquals(0, stat.misReplicationCount());
   }
+
+  @Test
+  public void testOutOfServiceNodesNotSelected() throws SCMException {
+    List<DatanodeDetails> datanodeDetails =
+        policy.chooseDatanodes(null, null, 1, 0, 0);
+    Assert.assertEquals(1, datanodeDetails.size());

Review comment:
       I guess those lines are not really needed. My intention was to show we can get a node when all are in service, but then only get an IN_SERVICE node (or exception) if only 1 node is IN_SERVICE. However those lines are not very useful at all. I will remove them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org