You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Arsnael (via GitHub)" <gi...@apache.org> on 2024/05/07 10:50:29 UTC
[PR] JAMES-3955 RabbitMQ works Backports [james-project]
Arsnael opened a new pull request, #2236:
URL: https://github.com/apache/james-project/pull/2236
Just https://github.com/apache/james-project/pull/1778 for now (was busy on other things in parallel)
Need as well to backport:
- https://github.com/apache/james-project/pull/1789
- https://github.com/apache/james-project/pull/1802
At least I want to see the CI and if tests are green on what I've been doing, as I had to adapt the code on some parts to fit the backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1595925257
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
That's really annoying on a maintenance branch.
Please offer me a way to still use 3.8 and turn off via system properties whatever options was not there yet in 3.8...
(Full retro-compatibility should be achievable)
And document it fully in the upgrade instructions.
My expectations:
```
XYZ option used requires rabbit 3.12
However -DdisableXYZ=true JVM option will disable XYZ and allow you to still use 3.8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1596178796
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
Technically it is? Just thought if we backport a feature where rabbitmq 3.12 is necessary if you want to use it, the code should be upgraded to use it as well at least. Does not force people to upgrade to it though, and the doc changes are actually quite clear on that.
It is still retro compatible (even in our current master branch). If you look the change in upgrade instructions in commit Increase consumer timeout foir TaskManagerWorkQueue, I think it's rather clear:
```
If you want the old behavior where consumer timeout defaults to 30 minutes, you can either not upgrade your RabbitMQ or set `task.queue.consumer.timeout=30minutes` in `rabbitmq.properties`.
```
But sure...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1597221477
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
`I want the old behaviour` is not the same as "I can still use rabbit 3.8" (which needs to be tested at the very least, and is another kind of breaking change at least to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1596178796
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
Technically it is? Just thought if we backport a feature where rabbitmq 3.12 is necessary if you want to use it, the code should be upgraded to use it as well at least. Does not force people to upgrade to it though, and the doc changes are actually quite clear on that.
It is still retro compatible (even in our current master branch). If you look the change in upgrade instructions in commit Increase consumer timeout foir TaskManagerWorkQueue, I think it's rather clear:
```
If you want the old behavior where consumer timeout defaults to 30 minutes, you can either not upgrade your RabbitMQ or set `task.queue.consumer.timeout=30minutes` in `rabbitmq.properties`.
```
If it's just a matter of reverting a few docker-compose files that nobody will look at though likely anyways then sure I can do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1596178796
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
Technically it is? Just thought if we backport a feature where rabbitmq 3.12 is necessary if you want to use it, the code should be upgraded to use it as well at least. Does not force people to upgrade to it though, and the doc changes are actually quite clear on that.
It is still retro compatible (even in our current master branch). If you look the change in upgrade instructions in commit Increase consumer timeout foir TaskManagerWorkQueue, I think it's rather clear:
```
If you want the old behavior where consumer timeout defaults to 30 minutes, you can either not upgrade your RabbitMQ or set `task.queue.consumer.timeout=30minutes` in `rabbitmq.properties`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2236:
URL: https://github.com/apache/james-project/pull/2236#discussion_r1597799018
##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -22,7 +22,7 @@ Third party compulsory dependencies:
----
$ docker run -d --network james -p 9042:9042 --name=cassandra cassandra:3.11.10
$ docker run -d --network james -p 9200:9200 --name=elasticsearch --env 'discovery.type=single-node' docker.elastic.co/elasticsearch/elasticsearch:7.10.2
-$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.8.18-management
+$ docker run -d --network james -p 5672:5672 -p 15672:15672 --name=rabbitmq rabbitmq:3.12.1-management
Review Comment:
The commit has been removed, the all code is compiling and testing back on rabbbitmq 3.8, and it's green.
Need something else? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3955 RabbitMQ works Backports [3.7.x] [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #2236:
URL: https://github.com/apache/james-project/pull/2236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org