You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/30 00:14:28 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #3890: Cleanup the use of Float primitive wrapper.
BradWalker opened a new pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890
As of Java 9, the VM can do a better job of handling the conversion from a float primitive to a Float Object or vice versa.
This is an extension of the work done in #2498.
No tests have been touched as those expressly need to manage the conversion.
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker merged pull request #3890: Cleanup the use of Float primitive wrapper.
Posted by GitBox <gi...@apache.org>.
BradWalker merged pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #3890: Cleanup the use of Float primitive wrapper.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890#issuecomment-1084794043
Hey @lkishalmi , can I count you as a reviewer of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker edited a comment on pull request #3890: Cleanup the use of Float primitive wrapper.
Posted by GitBox <gi...@apache.org>.
BradWalker edited a comment on pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890#issuecomment-1084793313
> how do you select the sub-projects you are cleaning up? I am wondering if it would be better to continue adding more commits to this PR until it is complete and all types are covered in the files you touched. So that we can review the switch blocks once instead of 8 times :)
Hey @mbien ,
Most of the "rust removal" work that I do, is done to try and make it easy for a reviewer. For example, the "new Float" work this change covers should just be about Floats. I find it easier for me to make changes this way and if I had to review, it makes things easier for me to think in those terms.
Changes required for the "new Double" are going to be really large (i.e. lots of different files). So that really should stand on it's own.
Also, I did try and bundle together the Byte & Short changes since they were reasonable to do and review.
Can I count you as an approver? 8-)
BTW, hang in there.. I'm almost done..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3890: Cleanup the use of Float primitive wrapper.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890#issuecomment-1084324758
how do you select the sub-projects you are cleaning up? I am wondering if it would be better to continue adding more commits to this PR until it is complete and all types are covered in the files you touched. So that we can review the switch blocks once instead of 8 times :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #3890: Cleanup the use of Float primitive wrapper.
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #3890:
URL: https://github.com/apache/netbeans/pull/3890#issuecomment-1084793313
> how do you select the sub-projects you are cleaning up? I am wondering if it would be better to continue adding more commits to this PR until it is complete and all types are covered in the files you touched. So that we can review the switch blocks once instead of 8 times :)
Hey @mbien ,
Most of the "rust removal" work that I do, is done to try and make it easy for a reviewer. For example, the "new Float" work this change covers should just be about Floats. I find it easier for me to make changes this way and if I had to review, it makes things easier for me to think in those terms.
Changes required for the "new Double" are going to be really large (i.e. lots of different files). So that really should stand on it's own.
Also, I did try and bundle together the Byte & Short changes since they were reasonable to do and review.
Can I could you as an approver? 8-)
BTW, hang in there.. I'm almost done..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists