You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/24 16:02:12 UTC

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on a change in pull request #8722:
URL: https://github.com/apache/kafka/pull/8722#discussion_r429650887



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java
##########
@@ -193,15 +192,6 @@
     public static final String INTER_WORKER_VERIFICATION_ALGORITHMS_DOC = "A list of permitted algorithms for verifying internal requests";
     public static final List<String> INTER_WORKER_VERIFICATION_ALGORITHMS_DEFAULT = Collections.singletonList(INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT);
 
-    private static final Validator REPLICATION_FACTOR_VALIDATOR = LambdaValidator.with(

Review comment:
       These had to be moved out of this class, or else tests for `StandaloneHerder` would break. They are not reused here as well as `TopicCreationConfig`

##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java
##########
@@ -193,15 +192,6 @@
     public static final String INTER_WORKER_VERIFICATION_ALGORITHMS_DOC = "A list of permitted algorithms for verifying internal requests";
     public static final List<String> INTER_WORKER_VERIFICATION_ALGORITHMS_DEFAULT = Collections.singletonList(INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT);
 
-    private static final Validator REPLICATION_FACTOR_VALIDATOR = LambdaValidator.with(

Review comment:
       These had to be moved out of this class, or else tests for `StandaloneHerder` would break. They are now reused here as well as `TopicCreationConfig`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org