You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/18 13:14:40 UTC

[GitHub] [hbase] Reidddddd commented on a change in pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

Reidddddd commented on a change in pull request #1923:
URL: https://github.com/apache/hbase/pull/1923#discussion_r442194628



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -230,7 +243,7 @@ public FSHLog(final FileSystem fs, final Path rootDir, final String logDir,
     this.disruptor.getRingBuffer().next();
     int maxHandlersCount = conf.getInt(HConstants.REGION_SERVER_HANDLER_COUNT, 200);
     this.ringBufferEventHandler = new RingBufferEventHandler(
-        conf.getInt("hbase.regionserver.hlog.syncer.count", 5), maxHandlersCount);
+        conf.getInt("hbase.regionserver.hlog.syncer.count", defaultSyncerCount), maxHandlersCount);

Review comment:
       I think your patch get wrong to my idea. The inching point is `maxHandlersCount` not `hbase.regionserver.hlog.syncer.count`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org