[jira] [Commented] (PHOENIX-5455) IndexedKeyValue creation fails after HBASE-22034

["Geoffrey Jacoby (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918164#comment-16918164 ] 

Geoffrey Jacoby commented on PHOENIX-5455:
------------------------------------------

Uploaded a patch for a future 4.14.3-HBase-1.5, and opened a PR for 4.x-HBase-1.5, part of 4.15. It will also need a separate patch for master, because the proper way to create Cells changed in HBase 2.x. 

> IndexedKeyValue creation fails after HBASE-22034
> ------------------------------------------------
>
>                 Key: PHOENIX-5455
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5455
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 4.14.3
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Blocker
>             Fix For: 4.15.0
>
>         Attachments: PHOENIX-5455-4.14-HBase-1.5.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HBASE-22034 backported to branch-1 HBASE-21401 (adding several validation checks to KeyValue creation) and HBASE-22032 (adding a null check for the row key to KeyValue creation). It will first be released in HBase 1.5.
> In Phoenix 4.14.2 we included PHOENIX-5188, which adds logic to initialize IndexedKeyValues with the appropriate row key and offsets, so that it can pass the new check in HBASE-22032. However, it did not correctly handle all the checks in HBASE-21401.
> When testing 4.14.3 of Phoenix with an HBase version containing HBASE-22034, we see lots of errors like the following:
> java.lang.IllegalArgumentException: Overflow when reading key length at position=0, KeyValueBytesHex=foo, offset=0, length=3
> This will affect the future 4.15-HBase-1.5, and as well as any future release of a 4.14.3 based on HBase-1.5



--
This message was sent by Atlassian Jira
(v8.3.2#803003)