You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by fr...@apache.org on 2025/06/11 19:04:34 UTC

(logging-log4net) branch ImprovementRemoteSyslogApp created (now 01239415)

This is an automated email from the ASF dual-hosted git repository.

freeandnil pushed a change to branch ImprovementRemoteSyslogApp
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git


      at 01239415 code ordering fixed

This branch includes the following new commits:

     new 01239415 code ordering fixed

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(logging-log4net) 01/01: code ordering fixed

Posted by fr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

freeandnil pushed a commit to branch ImprovementRemoteSyslogApp
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git

commit 01239415b4ee12444856caa1254140a7dccad4d3
Author: Jan Friedrich <fr...@apache.org>
AuthorDate: Wed Jun 11 21:03:37 2025 +0200

    code ordering fixed
---
 src/log4net/Appender/RemoteSyslogAppender.cs | 29 +++++++++++++---------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/log4net/Appender/RemoteSyslogAppender.cs b/src/log4net/Appender/RemoteSyslogAppender.cs
index 6444155d..95a79a56 100644
--- a/src/log4net/Appender/RemoteSyslogAppender.cs
+++ b/src/log4net/Appender/RemoteSyslogAppender.cs
@@ -259,6 +259,10 @@ public enum SyslogFacility
     Local7 = 23
   }
 
+  private readonly BlockingCollection<byte[]> _sendQueue = new();
+  private CancellationTokenSource? _cts;
+  private Task? _pumpTask;
+  
   /// <summary>
   /// Initializes a new instance of the <see cref="RemoteSyslogAppender" /> class.
   /// </summary>
@@ -425,12 +429,15 @@ protected virtual void AppendMessage(string message, ref int characterIndex, Str
   /// Initialize the level to syslog severity mappings set on this appender.
   /// </para>
   /// </remarks>
-  //public override void ActivateOptions()
-  //{
-  //  base.ActivateOptions();
-  //  _levelMapping.ActivateOptions();
-  //}
-
+  public override void ActivateOptions()
+  {
+    base.ActivateOptions();
+    _levelMapping.ActivateOptions();
+    // Start the background pump
+    _cts = new CancellationTokenSource();
+    _pumpTask = Task.Run(() => ProcessQueueAsync(_cts.Token), CancellationToken.None);
+  }
+  
   /// <summary>
   /// Translates a log4net level to a syslog severity.
   /// </summary>
@@ -536,16 +543,6 @@ public class LevelSeverity : LevelMappingEntry
     /// </remarks>
     public SyslogSeverity Severity { get; set; }
   }
-  private readonly BlockingCollection<byte[]> _sendQueue = new();
-  private CancellationTokenSource? _cts;
-  private Task? _pumpTask;
-  public override void ActivateOptions()
-  {
-    base.ActivateOptions();
-    // Start the background pump
-    _cts = new CancellationTokenSource();
-    _pumpTask = Task.Run(() => ProcessQueueAsync(_cts.Token), CancellationToken.None);
-  }
 
   protected override void OnClose()
   {