mod_proxy_balancer.c build failure

[NormW <no...@bocnet.com.au>]

Greetings All,
Get a build failure on mod_proxy_balancer.c when building on a Win box 
for NetWare; seems like it needs something similar to following to get 
the var 'worker' declared ahead of time...


--- mod_proxy_balancer.c.orig	2005-10-05 17:59:36.728170000 +1000
+++ mod_proxy_balancer.c	2005-10-09 08:33:27.015625000 +1000
@@ -187,6 +187,8 @@
                                          char **route,
                                          char **url)
  {
+    proxy_worker *worker = NULL;
+
      if (!balancer->sticky)
          return NULL;
      /* Try to find the sticky route inside url */
@@ -208,7 +210,7 @@
          /* We have a route in path or in cookie
           * Find the worker that has this route defined.
           */
-        proxy_worker *worker =  find_route_worker(balancer, *route);
+        worker = find_route_worker(balancer, *route);
          if (worker && !PROXY_WORKER_IS_USABLE(worker)) {
              /* We have a worker that is unusable.
               * It can be in error or disabled, but in case

Norm

Re: mod_proxy_balancer.c build failure

[Ruediger Pluem <rp...@apache.org>]

On 10/09/2005 12:44 AM, NormW wrote:
> Greetings All,
> Get a build failure on mod_proxy_balancer.c when building on a Win box
> for NetWare; seems like it needs something similar to following to get
> the var 'worker' declared ahead of time...

Sorry my fault. Thanks for the patch Norm.
The original declaration was only C99 but not ANSI C compatible.
Fixed in r307389 (trunk) and r307393 (2.2.x).

Regards

Rüdiger