You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jason Pyeron <jp...@pdinc.us> on 2013/12/30 20:02:55 UTC

Apache-Legacy class adapters was RE: [OGNL] A new release

> -----Original Message-----
> From: Lukasz Lenart 
> Sent: Monday, December 30, 2013 10:51
> 
> 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
> > There are a lot of formatting chenges between the version 
> in git and apache svn.
> > I am still looking for "patches" in git not yet applied to 
> subversion, 
> > do you know of any?
> 
> All should be already applied or don't affect Apache's version

I was thinking that a set of classes to wrap the org.apache classes should be
made for users of the legacy releases until they are ready to update their code
bases.

What does anyone else think? Ping Struts folks...

Could those be an apache package? Or must they be from "elsewhere" since they
will have the non-conformant package names.

-Jason

--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.

 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: Lukasz Lenart  
> Sent: Tuesday, December 31, 2013 8:40
> 
> 2013/12/31 Benedikt Ritter <br...@apache.org>:
> >> > > The old OGNL (legacy) releases use the
> >> > >
> >> > > "package ognl;"
> >> > >
> >> > > declarations, where as the apache releases will use
> >> > >
> >> > > "package org.apache.commons.ognl;"
> >> > >
> >> > > I would create a set of proxy classes in the old package
> >> > space which
> >> > > call the classes in the new space.
> >> >
> >> > These will only be required for a small proportion of 
> users, so I 
> >> > suggest they are packaged in a separate jar.
> >>
> >> That was always assumed. The question would it be 
> appropiate for an 
> >> Apache release, or should it be released elsewhere.
> >>
> >
> > Our software usually uses the org.apache.commons namespace. I'm not 
> > sure if this is an absolute requirement. To me it feels like these 
> > adapters should be developed and maintained else where. Thoughts?
> 
> Introducing that proxies is a bad idea - Apache Ognl is a bit 
> different beast than original Ognl and it will never be a 
> drop-in replacement, you will have to migrate your code anyway.

One less thing to do then. Thanks.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Lukasz Lenart <lu...@apache.org>.
2013/12/31 Benedikt Ritter <br...@apache.org>:
>> > > The old OGNL (legacy) releases use the
>> > >
>> > > "package ognl;"
>> > >
>> > > declarations, where as the apache releases will use
>> > >
>> > > "package org.apache.commons.ognl;"
>> > >
>> > > I would create a set of proxy classes in the old package
>> > space which
>> > > call the classes in the new space.
>> >
>> > These will only be required for a small proportion of users,
>> > so I suggest they are packaged in a separate jar.
>>
>> That was always assumed. The question would it be appropiate for an Apache
>> release, or should it be released elsewhere.
>>
>
> Our software usually uses the org.apache.commons namespace. I'm not sure if
> this is an absolute requirement. To me it feels like these adapters should
> be developed and maintained else where. Thoughts?

Introducing that proxies is a bad idea - Apache Ognl is a bit
different beast than original Ognl and it will never be a drop-in
replacement, you will have to migrate your code anyway.


Regards
-- 
Ɓukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: Benedikt Ritter 
> Sent: Tuesday, December 31, 2013 6:05
> 
> 2013/12/31 Jason Pyeron <jp...@pdinc.us>
> 
> > > -----Original Message-----
> > > From: sebb
> > > Sent: Monday, December 30, 2013 17:17
> > >
> > > On 30 December 2013 21:21, Jason Pyeron <jp...@pdinc.us> wrote:
> > > >> -----Original Message-----
> > > >> From: Benedikt Ritter
> > > >> Sent: Monday, December 30, 2013 14:19
> > > >>
> > > >> Hello Jason,
> > > >>
> > > >> sorry, I don't understand what exactly you have in mind.
> > > Can you give
> > > >> some examples?
> > > >
> > > > The old OGNL (legacy) releases use the
> > > >
> > > > "package ognl;"
> > > >
> > > > declarations, where as the apache releases will use
> > > >
> > > > "package org.apache.commons.ognl;"
> > > >
> > > > I would create a set of proxy classes in the old package
> > > space which
> > > > call the classes in the new space.
> > >
> > > These will only be required for a small proportion of users, so I 
> > > suggest they are packaged in a separate jar.
> >
> > That was always assumed. The question would it be appropiate for an 
> > Apache release, or should it be released elsewhere.
> >
> 
> Our software usually uses the org.apache.commons namespace. 
> I'm not sure if this is an absolute requirement. To me it 
> feels like these adapters should be developed and maintained 
> else where. Thoughts?

The biggest user would be the struts group, that would be a strong reason for it
to be an Apache release.

A second reason for it to be an Apache release is, "why would a project switch
to the OGNL Commons release and then install a non Apache adapter?"

That being said, I would use an adaptor from a third party as long as the
license worked.

<snip/>


--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.

 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Benedikt Ritter <br...@apache.org>.
2013/12/31 Jason Pyeron <jp...@pdinc.us>

> > -----Original Message-----
> > From: sebb
> > Sent: Monday, December 30, 2013 17:17
> >
> > On 30 December 2013 21:21, Jason Pyeron <jp...@pdinc.us> wrote:
> > >> -----Original Message-----
> > >> From: Benedikt Ritter
> > >> Sent: Monday, December 30, 2013 14:19
> > >>
> > >> Hello Jason,
> > >>
> > >> sorry, I don't understand what exactly you have in mind.
> > Can you give
> > >> some examples?
> > >
> > > The old OGNL (legacy) releases use the
> > >
> > > "package ognl;"
> > >
> > > declarations, where as the apache releases will use
> > >
> > > "package org.apache.commons.ognl;"
> > >
> > > I would create a set of proxy classes in the old package
> > space which
> > > call the classes in the new space.
> >
> > These will only be required for a small proportion of users,
> > so I suggest they are packaged in a separate jar.
>
> That was always assumed. The question would it be appropiate for an Apache
> release, or should it be released elsewhere.
>

Our software usually uses the org.apache.commons namespace. I'm not sure if
this is an absolute requirement. To me it feels like these adapters should
be developed and maintained else where. Thoughts?

Benedikt


>
> >
> > >>
> > >> 2013/12/30 Jason Pyeron <jp...@pdinc.us>
> > >>
> > >> >
> > >> > > -----Original Message-----
> > >> > > From: Lukasz Lenart
> > >> > > Sent: Monday, December 30, 2013 10:51
> > >> > >
> > >> > > 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
> > >> > > > There are a lot of formatting chenges between the version
> > >> > > in git and apache svn.
> > >> > > > I am still looking for "patches" in git not yet applied to
> > >> > > subversion,
> > >> > > > do you know of any?
> > >> > >
> > >> > > All should be already applied or don't affect Apache's version
> > >> >
> > >> > I was thinking that a set of classes to wrap the
> > org.apache classes
> > >> > should be made for users of the legacy releases until they
> > >> are ready
> > >> > to update their code bases.
> > >> >
> > >> > What does anyone else think? Ping Struts folks...
> > >
> > > jpyeron@black /projects/struts
> > > $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test <snip/>
> > >
> > ./struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/
> > > accessor/O bjectProxyPropertyAccessor.java:import ognl.OgnlContext;
> > > <snip/>
> > >
> > > jpyeron@black /projects/struts
> > > $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test | wc -l
> > > 54
> > >
> > >> >
> > >> > Could those be an apache package? Or must they be from
> > "elsewhere"
> > >> > since they will have the non-conformant package names.
> > >> >
>
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> -                                                               -
> - Jason Pyeron                      PD Inc. http://www.pdinc.us -
> - Principal Consultant              10 West 24th Street #100    -
> - +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
> -                                                               -
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> This message is copyright PD Inc, subject to license 20080407P00.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

RE: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: sebb 
> Sent: Monday, December 30, 2013 17:17
> 
> On 30 December 2013 21:21, Jason Pyeron <jp...@pdinc.us> wrote:
> >> -----Original Message-----
> >> From: Benedikt Ritter
> >> Sent: Monday, December 30, 2013 14:19
> >>
> >> Hello Jason,
> >>
> >> sorry, I don't understand what exactly you have in mind. 
> Can you give 
> >> some examples?
> >
> > The old OGNL (legacy) releases use the
> >
> > "package ognl;"
> >
> > declarations, where as the apache releases will use
> >
> > "package org.apache.commons.ognl;"
> >
> > I would create a set of proxy classes in the old package 
> space which 
> > call the classes in the new space.
> 
> These will only be required for a small proportion of users, 
> so I suggest they are packaged in a separate jar.

That was always assumed. The question would it be appropiate for an Apache
release, or should it be released elsewhere.

> 
> >>
> >> 2013/12/30 Jason Pyeron <jp...@pdinc.us>
> >>
> >> >
> >> > > -----Original Message-----
> >> > > From: Lukasz Lenart
> >> > > Sent: Monday, December 30, 2013 10:51
> >> > >
> >> > > 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
> >> > > > There are a lot of formatting chenges between the version
> >> > > in git and apache svn.
> >> > > > I am still looking for "patches" in git not yet applied to
> >> > > subversion,
> >> > > > do you know of any?
> >> > >
> >> > > All should be already applied or don't affect Apache's version
> >> >
> >> > I was thinking that a set of classes to wrap the 
> org.apache classes 
> >> > should be made for users of the legacy releases until they
> >> are ready
> >> > to update their code bases.
> >> >
> >> > What does anyone else think? Ping Struts folks...
> >
> > jpyeron@black /projects/struts
> > $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test <snip/> 
> > 
> ./struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/
> > accessor/O bjectProxyPropertyAccessor.java:import ognl.OgnlContext; 
> > <snip/>
> >
> > jpyeron@black /projects/struts
> > $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test | wc -l
> > 54
> >
> >> >
> >> > Could those be an apache package? Or must they be from 
> "elsewhere"
> >> > since they will have the non-conformant package names.
> >> >


--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.

 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by sebb <se...@gmail.com>.
On 30 December 2013 21:21, Jason Pyeron <jp...@pdinc.us> wrote:
>> -----Original Message-----
>> From: Benedikt Ritter
>> Sent: Monday, December 30, 2013 14:19
>>
>> Hello Jason,
>>
>> sorry, I don't understand what exactly you have in mind. Can
>> you give some examples?
>
> The old OGNL (legacy) releases use the
>
> "package ognl;"
>
> declarations, where as the apache releases will use
>
> "package org.apache.commons.ognl;"
>
> I would create a set of proxy classes in the old package space which call the
> classes in the new space.

These will only be required for a small proportion of users, so I
suggest they are packaged in a separate jar.

>>
>> 2013/12/30 Jason Pyeron <jp...@pdinc.us>
>>
>> >
>> > > -----Original Message-----
>> > > From: Lukasz Lenart
>> > > Sent: Monday, December 30, 2013 10:51
>> > >
>> > > 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
>> > > > There are a lot of formatting chenges between the version
>> > > in git and apache svn.
>> > > > I am still looking for "patches" in git not yet applied to
>> > > subversion,
>> > > > do you know of any?
>> > >
>> > > All should be already applied or don't affect Apache's version
>> >
>> > I was thinking that a set of classes to wrap the org.apache classes
>> > should be made for users of the legacy releases until they
>> are ready
>> > to update their code bases.
>> >
>> > What does anyone else think? Ping Struts folks...
>
> jpyeron@black /projects/struts
> $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test
> <snip/>
> ./struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/accessor/O
> bjectProxyPropertyAccessor.java:import ognl.OgnlContext;
> <snip/>
>
> jpyeron@black /projects/struts
> $ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test | wc -l
> 54
>
>> >
>> > Could those be an apache package? Or must they be from "elsewhere"
>> > since they will have the non-conformant package names.
>> >
>
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> -                                                               -
> - Jason Pyeron                      PD Inc. http://www.pdinc.us -
> - Principal Consultant              10 West 24th Street #100    -
> - +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
> -                                                               -
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> This message is copyright PD Inc, subject to license 20080407P00.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Jason Pyeron <jp...@pdinc.us>.
> -----Original Message-----
> From: Benedikt Ritter 
> Sent: Monday, December 30, 2013 14:19
> 
> Hello Jason,
> 
> sorry, I don't understand what exactly you have in mind. Can 
> you give some examples?

The old OGNL (legacy) releases use the

"package ognl;"

declarations, where as the apache releases will use

"package org.apache.commons.ognl;"

I would create a set of proxy classes in the old package space which call the
classes in the new space.

> 
> 2013/12/30 Jason Pyeron <jp...@pdinc.us>
> 
> >
> > > -----Original Message-----
> > > From: Lukasz Lenart
> > > Sent: Monday, December 30, 2013 10:51
> > >
> > > 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
> > > > There are a lot of formatting chenges between the version
> > > in git and apache svn.
> > > > I am still looking for "patches" in git not yet applied to
> > > subversion,
> > > > do you know of any?
> > >
> > > All should be already applied or don't affect Apache's version
> >
> > I was thinking that a set of classes to wrap the org.apache classes 
> > should be made for users of the legacy releases until they 
> are ready 
> > to update their code bases.
> >
> > What does anyone else think? Ping Struts folks...

jpyeron@black /projects/struts
$ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test 
<snip/>
./struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/ognl/accessor/O
bjectProxyPropertyAccessor.java:import ognl.OgnlContext;
<snip/>

jpyeron@black /projects/struts
$ grep -r 'import ognl' . | grep -v ./.svn/ | grep -v test | wc -l
54

> >
> > Could those be an apache package? Or must they be from "elsewhere" 
> > since they will have the non-conformant package names.
> >


--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: Apache-Legacy class adapters was RE: [OGNL] A new release

Posted by Benedikt Ritter <br...@apache.org>.
Hello Jason,

sorry, I don't understand what exactly you have in mind. Can you give some
examples?

Benedikt


2013/12/30 Jason Pyeron <jp...@pdinc.us>

>
> > -----Original Message-----
> > From: Lukasz Lenart
> > Sent: Monday, December 30, 2013 10:51
> >
> > 2013/12/30 Jason Pyeron <jp...@pdinc.us>:
> > > There are a lot of formatting chenges between the version
> > in git and apache svn.
> > > I am still looking for "patches" in git not yet applied to
> > subversion,
> > > do you know of any?
> >
> > All should be already applied or don't affect Apache's version
>
> I was thinking that a set of classes to wrap the org.apache classes should
> be
> made for users of the legacy releases until they are ready to update their
> code
> bases.
>
> What does anyone else think? Ping Struts folks...
>
> Could those be an apache package? Or must they be from "elsewhere" since
> they
> will have the non-conformant package names.
>
> -Jason
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> -                                                               -
> - Jason Pyeron                      PD Inc. http://www.pdinc.us -
> - Principal Consultant              10 West 24th Street #100    -
> - +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
> -                                                               -
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> This message is copyright PD Inc, subject to license 20080407P00.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter