You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Caleb Rackliffe (Jira)" <ji...@apache.org> on 2025/05/30 18:19:00 UTC
[jira] [Comment Edited] (CASSANDRA-20677) Adopt Unsafe::invokeCleaner for Direct ByteBuffer cleaning
[ https://issues.apache.org/jira/browse/CASSANDRA-20677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955283#comment-17955283 ]
Caleb Rackliffe edited comment on CASSANDRA-20677 at 5/30/25 6:18 PM:
----------------------------------------------------------------------
{{MultiNodeSAITest}} failures are just timeouts. I'm still looking at CASSANDRA-20307. Ignore them for now, although CASSANDRA-20639 may improve the situation a bit (and I see your branch hasn't rebased it in yet).
was (Author: maedhroz):
{{MultiNodeSAITest}} failures are just timeouts. I'm still looking at CASSANDRA-20307. Ignore them for now.
> Adopt Unsafe::invokeCleaner for Direct ByteBuffer cleaning
> ----------------------------------------------------------
>
> Key: CASSANDRA-20677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20677
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Sam Lightfoot
> Assignee: Sam Lightfoot
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> Per comments in FileUtils::clean
> {code:java}
> // TODO Once we can get rid of Java 8, it's simpler to call sun.misc.Unsafe.invokeCleaner(ByteBuffer),
> // but need to take care of the attachment handling (i.e. whether 'buf' is a duplicate or slice) - that
> // is different in sun.misc.Unsafe.invokeCleaner and this implementation. {code}
> We can now use Unsafe.invokeCleaner to clean direct byte buffers which should tidy up the existing code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org