You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/04/19 23:29:37 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors

eric-haibin-lin commented on a change in pull request #10550: [MXNET-320] Support elemwise_add/sub between dense and csr tensors
URL: https://github.com/apache/incubator-mxnet/pull/10550#discussion_r182912098
 
 

 ##########
 File path: src/operator/tensor/elemwise_binary_op_basic.cc
 ##########
 @@ -166,6 +168,8 @@ The storage type of ``elemwise_sub`` output depends on storage types of inputs
 
    - elemwise_sub(row_sparse, row_sparse) = row_sparse
    - elemwise_sub(csr, csr) = csr
+   - elemwise_sub(dns, csr) = dns
 
 Review comment:
   We never use "dns" API doc. Either "default" or "dense" is fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services