[GitHub] [helix] junkaixue commented on a diff in pull request #2380: Refactor update and find threadpool for state transition messages

["junkaixue (via GitHub)" <gi...@apache.org>]

junkaixue commented on code in PR #2380:
URL: https://github.com/apache/helix/pull/2380#discussion_r1113479156


##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -191,8 +190,7 @@ public HelixTaskExecutor(ParticipantStatusMonitor participantStatusMonitor,
     _batchMessageExecutorService = Executors.newCachedThreadPool();
     _monitor.createExecutorMonitor("BatchMessageExecutor", _batchMessageExecutorService);
 
-    _resourcesThreadpoolChecked = Collections.newSetFromMap(new ConcurrentHashMap<>());
-    _transitionTypeThreadpoolChecked = Collections.newSetFromMap(new ConcurrentHashMap<>());
+    _threadpoolChecked = Collections.newSetFromMap(new ConcurrentHashMap<>());

Review Comment:
   How you can combine them? Say we just need the "resource" based thread pool, are you doing prefixing searching?
   
   
   This is already changing the logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org