You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by springml <gi...@git.apache.org> on 2016/04/04 07:39:09 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
GitHub user springml opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/812
[ZEPPELIN-789] Skip execution of a paragraph in case of error
### What is this PR for?
New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-789
### How should this be tested?
* Build this PR
* Create a notebook and add three paragraphs in it
* Make sure the first paragraph results in error. Easy way is to have syntax error
* Add some print statement in second paragraph and set skipOnError to true for second paragraph
* Add some more print in third paragraph
* Execute the notebook. Second paragraph execution should be skipped.
* Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/springml/incubator-zeppelin skipOnError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #812
----
commit bab2f8a30853aadf9809f23a3acbe450637d787a
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-01T11:48:22Z
SkipOnError feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-210924078
Does not seem like it, could you please close and reopen this PR to kick off Travis CI again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
GitHub user springml reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/812
[ZEPPELIN-789] Skip execution of a paragraph in case of error
### What is this PR for?
New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-789
### How should this be tested?
* Build this PR
* Create a notebook and add three paragraphs in it
* Make sure the first paragraph results in error. Easy way is to have syntax error
* Add some print statement in second paragraph and set skipOnError to true for second paragraph
* Add some more print in third paragraph
* Execute the notebook. Second paragraph execution should be skipped.
* Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/springml/incubator-zeppelin skipOnError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #812
----
commit bab2f8a30853aadf9809f23a3acbe450637d787a
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-01T11:48:22Z
SkipOnError feature
commit 92a7dce4d43ff20a68944ac2cf9a557618fdc730
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:35:56Z
Used run method for abort test
commit 59f0ba373179d5193f998a400743973685ab00a7
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:36:56Z
runNote function change reflected in test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
GitHub user springml reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/812
[ZEPPELIN-789] Skip execution of a paragraph in case of error
### What is this PR for?
New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-789
### How should this be tested?
* Build this PR
* Create a notebook and add three paragraphs in it
* Make sure the first paragraph results in error. Easy way is to have syntax error
* Add some print statement in second paragraph and set skipOnError to true for second paragraph
* Add some more print in third paragraph
* Execute the notebook. Second paragraph execution should be skipped.
* Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/springml/incubator-zeppelin skipOnError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #812
----
commit bab2f8a30853aadf9809f23a3acbe450637d787a
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-01T11:48:22Z
SkipOnError feature
commit 92a7dce4d43ff20a68944ac2cf9a557618fdc730
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:35:56Z
Used run method for abort test
commit 59f0ba373179d5193f998a400743973685ab00a7
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:36:56Z
runNote function change reflected in test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-211192549
Reopening as requested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
GitHub user springml reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/812
[ZEPPELIN-789] Skip execution of a paragraph in case of error
### What is this PR for?
New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-789
### How should this be tested?
* Build this PR
* Create a notebook and add three paragraphs in it
* Make sure the first paragraph results in error. Easy way is to have syntax error
* Add some print statement in second paragraph and set skipOnError to true for second paragraph
* Add some more print in third paragraph
* Execute the notebook. Second paragraph execution should be skipped.
* Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/springml/incubator-zeppelin skipOnError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #812
----
commit bab2f8a30853aadf9809f23a3acbe450637d787a
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-01T11:48:22Z
SkipOnError feature
commit 92a7dce4d43ff20a68944ac2cf9a557618fdc730
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:35:56Z
Used run method for abort test
commit 59f0ba373179d5193f998a400743973685ab00a7
Author: Samuel Alexander <sa...@palmtreeinfotech.com>
Date: 2016-04-04T10:36:56Z
runNote function change reflected in test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-205285005
We have some tests failing in this PR. But we are not getting any details of the failure.
Below is the error that we see
```
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated
```
How can we find more information to solve these test issues? Are these test failures caused by the code changes present in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-211215693
Again same error. There might be some issue with this PR. But how can I find it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by springml <gi...@git.apache.org>.
Github user springml closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-789] Skip execution of ...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/812#issuecomment-220217140
Could you reopen PR to trigger CI? The build failure doesn't seem to be related
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---