[GitHub] [cassandra] maedhroz commented on a change in pull request #735: Cassandra 16092: CEP-7 port Index Group for Storage Attached Index

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #735:
URL: https://github.com/apache/cassandra/pull/735#discussion_r696116146



##########
File path: src/java/org/apache/cassandra/index/Index.java
##########
@@ -364,6 +382,23 @@ default SSTableFlushObserver getFlushObserver(Descriptor descriptor, OperationTy
      */
     public AbstractType<?> customExpressionValueType();
 
+    /**
+     * If the index supports custom search expressions using the
+     * {@code SELECT * FROM table WHERE expr(index_name, expression)} syntax, this method should return a new
+     * {@link RowFilter.CustomExpression} for the specified expression value. Index implementations may provide their
+     * own implementations using method {@link RowFilter.CustomExpression#isSatisfiedBy(TableMetadata, DecoratedKey, Row)}
+     * to filter reconciled rows in the coordinator. Otherwise, the default implementation will accept all rows.
+     * See DB-2185 and DSP-16537 for further details.
+     *
+     * @param metadata the indexed table metadata
+     * @param value the custom expression value
+     * @return a custom index expression for the specified value
+     */
+    default RowFilter.CustomExpression customExpressionFor(TableMetadata metadata, ByteBuffer value)

Review comment:
       That works for me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org